Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Algebra/Homology): behaviour of the total complex with respect to the shifts #10854

Closed
wants to merge 23 commits into from
Closed

[Merged by Bors] - feat(Algebra/Homology): behaviour of the total complex with respect to the shifts #10854

wants to merge 23 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Feb 22, 2024 •
edited by github-actions bot

@joelriou joelriou added the t-category-theory Category theory label Feb 22, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Feb 22, 2024
@joelriou joelriou changed the title feat(Algebra/Homology): behaviour of the total complex with the shift on the first variable feat(Algebra/Homology): behaviour of the total complex with the shifts Feb 22, 2024
@joelriou joelriou mentioned this pull request Feb 23, 2024
Closed
4 tasks
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 23, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 23, 2024
@joelriou joelriou changed the title feat(Algebra/Homology): behaviour of the total complex with the shifts feat(Algebra/Homology): behaviour of the total complex with respect to the shifts Feb 23, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Mar 12, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 13, 2024
@joelriou joelriou added the awaiting-review The author would like community review of the PR label Mar 13, 2024
@TwoFX TwoFX added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 18, 2024
@joelriou joelriou added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 18, 2024
TwoFX
TwoFX approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors d+

Mathlib/Algebra/Homology/TotalComplexShift.lean
simp only [ι_totalDesc_assoc, CochainComplex.shiftFunctor_obj_X', ι_totalDesc, comp_id]
exact ((shiftFunctor₁ C x).obj K).XXIsoOfEq_inv_ιTotal _ (by omega) rfl _ _

lemma D₁_totalShift₁XIso_hom (n₀ n₁ n₀' n₁' : ℤ) (h₀ : n₀ + x = n₀') (h₁ : n₁ + x = n₁') :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one and the lemma below are also missing @[reassoc]?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@mathlib-bors
Copy link

mathlib-bors bot commented Mar 19, 2024

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Mar 19, 2024
@joelriou
Copy link
Collaborator Author

Thanks for the review!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Mar 19, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 19, 2024
@joelriou
feat(Algebra/Homology): behaviour of the total complex with respect t…
921f506 
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Mar 19, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Homology): behaviour of the total complex with respect to the shifts [Merged by Bors] - feat(Algebra/Homology): behaviour of the total complex with respect to the shifts Mar 19, 2024
@mathlib-bors mathlib-bors bot closed this Mar 19, 2024
@mathlib-bors mathlib-bors bot deleted the total-complex-shift branch March 19, 2024 11:22
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
@joelriou @dagurtomas
feat(Algebra/Homology): behaviour of the total complex with respect t…
cf35c12 
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
utensil pushed a commit that referenced this pull request Mar 26, 2024
@joelriou @utensil
feat(Algebra/Homology): behaviour of the total complex with respect t…
a9c9be6 
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Louddy pushed a commit that referenced this pull request Apr 15, 2024
@joelriou @Louddy
feat(Algebra/Homology): behaviour of the total complex with respect t…
7219e2a 
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
@joelriou @atarnoam
feat(Algebra/Homology): behaviour of the total complex with respect t…
5f8ceb9 
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
@joelriou @uniwuni
feat(Algebra/Homology): behaviour of the total complex with respect t…
b786492 
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
callesonne pushed a commit that referenced this pull request Apr 22, 2024
@joelriou @callesonne
feat(Algebra/Homology): behaviour of the total complex with respect t…
10f63ba 
…o the shifts (#10854)

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX TwoFX approved these changes

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joelriou @leanprover-community-mathlib4-bot @TwoFX