Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: the spectrum of a diagonal matrix is the range of the diagonal #13837

Closed
wants to merge 23 commits into from

Conversation

JonBannon
Copy link
Collaborator

We add various theorems that assert the spectrum of a diagonal matrix is the range of the diagonal viewed as a function.

Co-Authored by @j-loreaux


Open in Gitpod

Copy link

github-actions bot commented Jun 14, 2024

PR summary 0561c3b868

Import changes

No significant changes to the import graph


Declarations diff

+ hasEigenvalue_toLin'_diagonal_iff
+ hasEigenvalue_toLin_diagonal_iff
+ hasEigenvector_toLin'_diagonal
+ hasEigenvector_toLin_diagonal
+ spectrum_diagonal

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@JonBannon JonBannon added awaiting-review new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! labels Jun 14, 2024
Mathlib/LinearAlgebra/Eigenspace/Basic.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Eigenspace/Basic.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Eigenspace/Basic.lean Outdated Show resolved Hide resolved
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jun 16, 2024
@JonBannon JonBannon added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 21, 2024
….basisFun` versions of `hasEigenvalue_toLin_diagonal_iff`
@JonBannon JonBannon requested a review from j-loreaux June 23, 2024 13:40
@JonBannon
Copy link
Collaborator Author

JonBannon commented Jun 23, 2024 via email

Mathlib/LinearAlgebra/Eigenspace/Matrix.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Eigenspace/Matrix.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Eigenspace/Matrix.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Eigenspace/Matrix.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Eigenspace/Matrix.lean Outdated Show resolved Hide resolved
Comment on lines 13 to 14
This file collects results about eigenvectors, eigenvalues and spectrum specific to matrices
over a field.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only the last result needs R to be a field. The rest hold under weaker assumptions. Please try to minimize the assumptions you need on R by changing them per theorem as needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Will do this first thing tomorrow. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also adjust the docstring accordingly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly! I'll do this now...

Mathlib/LinearAlgebra/Eigenspace/Matrix.lean Outdated Show resolved Hide resolved
@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jun 24, 2024
JonBannon and others added 3 commits June 24, 2024 16:53
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Mathlib/LinearAlgebra/Eigenspace/Matrix.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Eigenspace/Matrix.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Eigenspace/Matrix.lean Outdated Show resolved Hide resolved
@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jun 25, 2024
JonBannon and others added 2 commits June 25, 2024 16:30
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
…ted the hypotheses in the theorems they went with, as Jireh suggested.
@JonBannon JonBannon added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 25, 2024
@JonBannon JonBannon requested a review from j-loreaux June 25, 2024 20:46
@j-loreaux
Copy link
Collaborator

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by j-loreaux.

@j-loreaux j-loreaux changed the title feat : added SpectrumDiagonal section feat: the spectrum of a diagonal matrix is the range of the diagonal Jun 27, 2024
@JonBannon JonBannon requested a review from dupuisf June 27, 2024 18:17
@dupuisf
Copy link
Contributor

dupuisf commented Jun 27, 2024

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 27, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 27, 2024
…13837)

We add various theorems that assert the spectrum of a diagonal matrix is the range of the diagonal viewed as a function.

Co-Authored by @j-loreaux



Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the spectrum of a diagonal matrix is the range of the diagonal [Merged by Bors] - feat: the spectrum of a diagonal matrix is the range of the diagonal Jun 27, 2024
@mathlib-bors mathlib-bors bot closed this Jun 27, 2024
@mathlib-bors mathlib-bors bot deleted the SpectrumDiagonal branch June 27, 2024 19:05
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
…13837)

We add various theorems that assert the spectrum of a diagonal matrix is the range of the diagonal viewed as a function.

Co-Authored by @j-loreaux



Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
…atrices over an RCLike Field (#13697)

This file contains the requisite lemmas needed to define a `ContinuousFunctionalCalculus` for Hermitian Matrices over an RCLike Field.

- [x] depends on: #13729
- [x] depends on: #13765
- [x] depends on : #13837
- [x] depends on : #13838

Co-Authored by @j-loreaux



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
…atrices over an RCLike Field (#13697)

This file contains the requisite lemmas needed to define a `ContinuousFunctionalCalculus` for Hermitian Matrices over an RCLike Field.

- [x] depends on: #13729
- [x] depends on: #13765
- [x] depends on : #13837
- [x] depends on : #13838

Co-Authored by @j-loreaux



Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants