Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat : added eigenvalues_mem_spectrum_real and supporting RCLike coercion results #13838

Closed
wants to merge 19 commits into from

Conversation

JonBannon
Copy link
Collaborator

Added several RCLike to real coercion results to support the result that eigenvalues of a hermitian matrix belong to the real spectrum of that matrix, and included this result.

Co-Authored by @j-loreaux


Open in Gitpod

@JonBannon JonBannon added awaiting-review new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! labels Jun 14, 2024
Copy link

github-actions bot commented Jun 14, 2024

PR summary c01bd71d00

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.LinearAlgebra.Matrix.Spectrum 1591 1594 +3 (+0.19%)

Declarations diff

+ _root_.Module.End.toContinuousLinearMap
+ eigenvalues_mem_spectrum_real
+ spectrum_toEuclideanLin

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Mathlib/LinearAlgebra/Matrix/Spectrum.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Matrix/Spectrum.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Matrix/Spectrum.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Matrix/Spectrum.lean Outdated Show resolved Hide resolved
@JonBannon JonBannon changed the title feat : added eigenvalue_mem_real and supporting RCLike coercion results feat : added eigenvalue_mem__spectrum_real and supporting RCLike coercion results Jun 15, 2024
@JonBannon JonBannon changed the title feat : added eigenvalue_mem__spectrum_real and supporting RCLike coercion results feat : added eigenvalues_mem__spectrum_real and supporting RCLike coercion results Jun 15, 2024
@Ruben-VandeVelde Ruben-VandeVelde changed the title feat : added eigenvalues_mem__spectrum_real and supporting RCLike coercion results feat : added eigenvalues_mem_spectrum_real and supporting RCLike coercion results Jun 15, 2024
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Mathlib/LinearAlgebra/Matrix/Spectrum.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Matrix/Spectrum.lean Outdated Show resolved Hide resolved
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@JonBannon
Copy link
Collaborator Author

JonBannon commented Jun 17, 2024 via email

JonBannon and others added 2 commits June 21, 2024 17:09
As Ruben suggested!

Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style, naming, and some simplification

Mathlib/LinearAlgebra/Matrix/Spectrum.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Matrix/Spectrum.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Matrix/Spectrum.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Matrix/Spectrum.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Matrix/Spectrum.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Module/FiniteDimension.lean Outdated Show resolved Hide resolved
@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Jun 24, 2024
JonBannon and others added 8 commits June 24, 2024 20:11
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@JonBannon JonBannon added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 25, 2024
@JonBannon JonBannon requested a review from j-loreaux June 25, 2024 20:53
@j-loreaux
Copy link
Collaborator

I've had a lot of input here, so

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by j-loreaux.

@dupuisf
Copy link
Contributor

dupuisf commented Jun 26, 2024

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 26, 2024
…ercion results (#13838)

Added several RCLike to real coercion results to support the result that eigenvalues of a hermitian matrix belong to the real spectrum of that matrix, and included this result.

Co-Authored by @j-loreaux



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat : added eigenvalues_mem_spectrum_real and supporting RCLike coercion results [Merged by Bors] - feat : added eigenvalues_mem_spectrum_real and supporting RCLike coercion results Jun 26, 2024
@mathlib-bors mathlib-bors bot closed this Jun 26, 2024
@mathlib-bors mathlib-bors bot deleted the toEuclideanLinRCLikeHermitianSpectrum branch June 26, 2024 18:17
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
…ercion results (#13838)

Added several RCLike to real coercion results to support the result that eigenvalues of a hermitian matrix belong to the real spectrum of that matrix, and included this result.

Co-Authored by @j-loreaux



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
…ercion results (#13838)

Added several RCLike to real coercion results to support the result that eigenvalues of a hermitian matrix belong to the real spectrum of that matrix, and included this result.

Co-Authored by @j-loreaux



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
…atrices over an RCLike Field (#13697)

This file contains the requisite lemmas needed to define a `ContinuousFunctionalCalculus` for Hermitian Matrices over an RCLike Field.

- [x] depends on: #13729
- [x] depends on: #13765
- [x] depends on : #13837
- [x] depends on : #13838

Co-Authored by @j-loreaux



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
mathlib-bors bot pushed a commit that referenced this pull request Jul 9, 2024
…atrices over an RCLike Field (#13697)

This file contains the requisite lemmas needed to define a `ContinuousFunctionalCalculus` for Hermitian Matrices over an RCLike Field.

- [x] depends on: #13729
- [x] depends on: #13765
- [x] depends on : #13837
- [x] depends on : #13838

Co-Authored by @j-loreaux



Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants