-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat : added eigenvalues_mem_spectrum_real
and supporting RCLike coercion results
#13838
Conversation
…ll as that result.
PR summary c01bd71d00Import changesDependency changes
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
eigenvalue_mem_real
and supporting RCLike coercion resultseigenvalue_mem__spectrum_real
and supporting RCLike coercion results
eigenvalue_mem__spectrum_real
and supporting RCLike coercion resultseigenvalues_mem__spectrum_real
and supporting RCLike coercion results
eigenvalues_mem__spectrum_real
and supporting RCLike coercion resultseigenvalues_mem_spectrum_real
and supporting RCLike coercion results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Ah, ok. I'm happy to commit the suggestion if it confirms to style
guidelines!
…On Mon, Jun 17, 2024, 10:36 AM Eric Wieser ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Mathlib/LinearAlgebra/Matrix/Spectrum.lean
<#13838 (comment)>
:
> + AlgEquiv.spectrum_eq ((AlgEquiv.trans ((toEuclideanCLM : Matrix n n 𝕜 ≃⋆ₐ[𝕜]
+ EuclideanSpace 𝕜 n →L[𝕜] EuclideanSpace 𝕜 n) : Matrix n n 𝕜 ≃ₐ[𝕜]
+ EuclideanSpace 𝕜 n →L[𝕜] EuclideanSpace 𝕜 n))
+ (Module.End.toContinuousLinearMap (EuclideanSpace 𝕜 n)).symm) _
Yes, I think this is a style change: the idea is to reflect parenthesis
nesting with indentation.
—
Reply to this email directly, view it on GitHub
<#13838 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOJJJTRRC2TGDJO5O2ZGPWLZH3YAPAVCNFSM6AAAAABJKW5JPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMRTGA4TEMJSGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
As Ruben suggested! Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style, naming, and some simplification
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
…b.com/leanprover-community/mathlib4 into toEuclideanLinRCLikeHermitianSpectrum
…ms, associated sections removed.
…lts, as Jireh suggested.
I've had a lot of input here, so maintainer merge |
🚀 Pull request has been placed on the maintainer queue by j-loreaux. |
Thanks! bors r+ |
…ercion results (#13838) Added several RCLike to real coercion results to support the result that eigenvalues of a hermitian matrix belong to the real spectrum of that matrix, and included this result. Co-Authored by @j-loreaux Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Pull request successfully merged into master. Build succeeded: |
eigenvalues_mem_spectrum_real
and supporting RCLike coercion resultseigenvalues_mem_spectrum_real
and supporting RCLike coercion results
…ercion results (#13838) Added several RCLike to real coercion results to support the result that eigenvalues of a hermitian matrix belong to the real spectrum of that matrix, and included this result. Co-Authored by @j-loreaux Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
…ercion results (#13838) Added several RCLike to real coercion results to support the result that eigenvalues of a hermitian matrix belong to the real spectrum of that matrix, and included this result. Co-Authored by @j-loreaux Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
…atrices over an RCLike Field (#13697) This file contains the requisite lemmas needed to define a `ContinuousFunctionalCalculus` for Hermitian Matrices over an RCLike Field. - [x] depends on: #13729 - [x] depends on: #13765 - [x] depends on : #13837 - [x] depends on : #13838 Co-Authored by @j-loreaux Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
…atrices over an RCLike Field (#13697) This file contains the requisite lemmas needed to define a `ContinuousFunctionalCalculus` for Hermitian Matrices over an RCLike Field. - [x] depends on: #13729 - [x] depends on: #13765 - [x] depends on : #13837 - [x] depends on : #13838 Co-Authored by @j-loreaux Co-authored-by: JonBannon <59937998+JonBannon@users.noreply.github.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Added several RCLike to real coercion results to support the result that eigenvalues of a hermitian matrix belong to the real spectrum of that matrix, and included this result.
Co-Authored by @j-loreaux