New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - sync: update sha from backports #3079
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneugster
added
WIP
Work in progress
mathlib3-pair
This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged
labels
Mar 24, 2023
Can you locate the mathlib4 PRs that made these changes and link them in the description? |
eric-wieser
reviewed
Mar 27, 2023
joneugster
added
awaiting-review
The author would like community review of the PR
and removed
WIP
Work in progress
labels
Mar 27, 2023
bors merge Thanks! |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 27, 2023
bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
These files have been primarily modified by backports and need little modification: * `topology.basic`: #1826 - modified with a porting note, which can now be removed * `data.real.cau_seq_completion`: #1469 - not a backport, but forgot to update the SHA * `order.filter.n_ary.basic`: #1967 - this PR forgot to update the SHA * `ring_theory.valuation.basic`: The change is a small golf that is now included in this PR Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
sync: update sha from backports
[Merged by Bors] - sync: update sha from backports
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mathlib3-pair
This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files have been primarily modified by backports and need little modification:
topology.basic
: [Merged by Bors] - feat: port Topology.Basic #1826 - modified with a porting note, which can now be removeddata.real.cau_seq_completion
: [Merged by Bors] - feat: port Data.Real.CauSeqCompletion #1469 - not a backport, but forgot to update the SHAorder.filter.n_ary.basic
: [Merged by Bors] - chore: golf Order.Filter.NAry #1967 - this PR forgot to update the SHAring_theory.valuation.basic
: The change is a small golf that is now included in this PRtopology.basic
@bcfa726826abd57587355b4b5b7e78ad6527b7e4
..88b8a77d63a702923d9bee05e9e454ebc22aa766
data.real.cau_seq_completion
@40acfb6aa7516ffe6f91136691df012a64683390
..cf4c49c445991489058260d75dae0ff2b1abca28
order.filter.n_ary
@1f0096e6caa61e9c849ec2adbd227e960e9dff58
..78f647f8517f021d839a7553d5dc97e79b508dea
ring_theory.valuation.basic
@da420a8c6dd5bdfb85c4ced85c34388f633bc6ff
..2196ab363eb097c008d4497125e0dde23fb36db2