Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Real.CauSeqCompletion #1469

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Data.Real.CauSeqCompletion #1469

wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 10, 2023 •
edited

Unreverts #1440

Open in Gitpod

@eric-wieser eric-wieser added blocked-by-other-PR This PR depends on another PR which is still in the queue. awaiting-author A reviewer has asked the author a question or requested changes labels Jan 10, 2023
@hrmacbeth hrmacbeth added the mathlib-port This is a port of a theory file from mathlib. label Jan 11, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jan 11, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 11, 2023
@ChrisHughes24 ChrisHughes24 changed the title feat: port Mathlib.Data.Real.CauSeqCompletion feat: port Data.Real.CauSeqCompletion Jan 12, 2023
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't know why we had to revert #1440 over this, but it seems good to go now

@Ruben-VandeVelde Ruben-VandeVelde mentioned this pull request Jan 12, 2023
Closed
1 task
jcommelin
jcommelin approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 13, 2023
bors bot pushed a commit that referenced this pull request Jan 13, 2023
@eric-wieser @Ruben-VandeVelde
feat: port Data.Real.CauSeqCompletion (#1469)
d4e2fbc 
Unreverts #1440




Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 13, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Real.CauSeqCompletion [Merged by Bors] - feat: port Data.Real.CauSeqCompletion Jan 13, 2023
@bors bors bot closed this Jan 13, 2023
@bors bors bot deleted the eric-wieser/restore-CauSeqCompletion branch January 13, 2023 09:15
eric-wieser
eric-wieser commented Jan 13, 2023
View reviewed changes
Mathlib/Data/Real/CauSeqCompletion.lean
simp only [div_eq_mul_inv, ofRat_inv, ofRat_mul]
#align cau_seq.completion.of_rat_div CauSeq.Completion.ofRat_div

-- Porting note: removed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ruben-VandeVelde: why did you remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1524

@eric-wieser
Copy link
Member Author

I really don't know why we had to revert #1440 over this, but it seems good to go now

Because:

jcommelin pushed a commit that referenced this pull request Jan 23, 2023
@eric-wieser @Ruben-VandeVelde @jcommelin
feat: port Data.Real.CauSeqCompletion (#1469)
6102753 
Unreverts #1440




Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@eric-wieser eric-wieser mentioned this pull request Mar 27, 2023
Closed
bors bot pushed a commit that referenced this pull request Mar 27, 2023
@joneugster @eric-wieser
sync: update sha from backports (#3079)
2d6e2be 
These files have been primarily modified by backports and need little modification:

* `topology.basic`: #1826 - modified with a porting note, which can now be removed
* `data.real.cau_seq_completion`: #1469 - not a backport, but forgot to update the SHA
* `order.filter.n_ary.basic`: #1967 - this PR forgot to update the SHA
* `ring_theory.valuation.basic`: The change is a small golf that is now included in this PR


Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eric-wieser @semorrison @jcommelin @Ruben-VandeVelde @hrmacbeth