[Merged by Bors] - feat: add Algebra.discr_localizationLocalization #6422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xroblot
force-pushed
the
xfr-localization_discriminant
branch
from
2cfb8e9
to
58ae073
Compare
xroblot
added
WIP
2 tasks
|
can you make the moving of the file be one commit? maybe with |
xroblot
force-pushed
the
xfr-localization_discriminant
branch
from
58ae073
to
6fc9e3c
Compare
xroblot
added
awaiting-review
leanprover-community-mathlib4-bot
added
the
merge-conflict
I used your suggestion and used |
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
lgtm! maintainer merge the diff is best seen here: |
|
🚀 Pull request has been placed on the maintainer queue by ericrbg. |
1 similar comment
|
🚀 Pull request has been placed on the maintainer queue by ericrbg. |
|
✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
We prove ```lean theorem Algebra.discr_localizationLocalization (b : Basis ι R S) : Algebra.discr Rₘ (b.localizationLocalization Rₘ M Aₘ) = algebraMap R Rₘ (Algebra.discr R b) ``` We need for that to prove the analogue for the trace of `Algebra.norm_localization` (that was the only result in `RingTheory.Localization.Norm`). Since the results are added to this file, it is renamed to `RingTheory.Localization.NormTrace` (not sure about the name though).
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
We prove ```lean theorem Algebra.discr_localizationLocalization (b : Basis ι R S) : Algebra.discr Rₘ (b.localizationLocalization Rₘ M Aₘ) = algebraMap R Rₘ (Algebra.discr R b) ``` We need for that to prove the analogue for the trace of `Algebra.norm_localization` (that was the only result in `RingTheory.Localization.Norm`). Since the results are added to this file, it is renamed to `RingTheory.Localization.NormTrace` (not sure about the name though).
semorrison
pushed a commit
that referenced
this pull request
Aug 15, 2023
We prove ```lean theorem Algebra.discr_localizationLocalization (b : Basis ι R S) : Algebra.discr Rₘ (b.localizationLocalization Rₘ M Aₘ) = algebraMap R Rₘ (Algebra.discr R b) ``` We need for that to prove the analogue for the trace of `Algebra.norm_localization` (that was the only result in `RingTheory.Localization.Norm`). Since the results are added to this file, it is renamed to `RingTheory.Localization.NormTrace` (not sure about the name though).
semorrison
pushed a commit
that referenced
this pull request
Aug 15, 2023
We prove ```lean theorem Algebra.discr_localizationLocalization (b : Basis ι R S) : Algebra.discr Rₘ (b.localizationLocalization Rₘ M Aₘ) = algebraMap R Rₘ (Algebra.discr R b) ``` We need for that to prove the analogue for the trace of `Algebra.norm_localization` (that was the only result in `RingTheory.Localization.Norm`). Since the results are added to this file, it is renamed to `RingTheory.Localization.NormTrace` (not sure about the name though).
semorrison
pushed a commit
that referenced
this pull request
Aug 17, 2023
We prove ```lean theorem Algebra.discr_localizationLocalization (b : Basis ι R S) : Algebra.discr Rₘ (b.localizationLocalization Rₘ M Aₘ) = algebraMap R Rₘ (Algebra.discr R b) ``` We need for that to prove the analogue for the trace of `Algebra.norm_localization` (that was the only result in `RingTheory.Localization.Norm`). Since the results are added to this file, it is renamed to `RingTheory.Localization.NormTrace` (not sure about the name though).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prove
We need for that to prove the analogue for the trace of
Algebra.norm_localization(that was the only result inRingTheory.Localization.Norm). Since the results are added to this file, it is renamed toRingTheory.Localization.NormTrace(not sure about the name though).