Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Sigma.Lex #646

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port Data.Sigma.Lex #646

wants to merge 11 commits into from

Conversation

riccardobrasca
Copy link
Member

mathlib3 sha: fd47bdf09e90f553519c712378e651975fe8c829

@riccardobrasca riccardobrasca added awaiting-review mathlib-port This is a port of a theory file from mathlib. labels Nov 18, 2022
mcdoll
mcdoll reviewed Nov 20, 2022
View reviewed changes
Mathlib/Data/Sigma/Lex.lean Outdated Show resolved Hide resolved
Mathlib/Data/Sigma/Lex.lean Outdated Show resolved Hide resolved
riccardobrasca and others added 4 commits November 20, 2022 11:39
@riccardobrasca @mcdoll
Update Mathlib/Data/Sigma/Lex.lean
ddaa26c 
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
@riccardobrasca @mcdoll
Update Mathlib/Data/Sigma/Lex.lean
f2b5883 
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
@riccardobrasca
Merge remote-tracking branch 'origin/master' into RB/sigma_lex
a2762ec
@riccardobrasca
fix doc
5b26953
Ruben-VandeVelde
Ruben-VandeVelde approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

j-loreaux
j-loreaux reviewed Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but overall looks good.

Mathlib/Data/Sigma/Lex.lean Outdated Show resolved Hide resolved
Mathlib/Data/Sigma/Lex.lean Outdated Show resolved Hide resolved
@j-loreaux j-loreaux added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Nov 22, 2022
@riccardobrasca riccardobrasca added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 22, 2022
@semorrison
Copy link
Contributor

bors merge

bors bot pushed a commit that referenced this pull request Nov 22, 2022
@riccardobrasca
feat: port Data.Sigma.Lex (#646)
3191ded 
mathlib3 sha: fd47bdf09e90f553519c712378e651975fe8c829
@bors
Copy link

bors bot commented Nov 22, 2022

Build failed:

@riccardobrasca
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Nov 23, 2022
@riccardobrasca @j-loreaux
feat: port Data.Sigma.Lex (#646)
dd656ba 
mathlib3 sha: fd47bdf09e90f553519c712378e651975fe8c829

Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@bors
Copy link

bors bot commented Nov 23, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Sigma.Lex [Merged by Bors] - feat: port Data.Sigma.Lex Nov 23, 2022
@bors bors bot closed this Nov 23, 2022
@bors bors bot deleted the RB/sigma_lex branch November 23, 2022 07:09
@github-actions github-actions bot mentioned this pull request Nov 23, 2022
Closed
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 23, 2022
@eric-wieser
chore(*): add mathlibport comments (#17686)
4afb682 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* leanprover-community/mathlib4#643
* leanprover-community/mathlib4#646
* leanprover-community/mathlib4#648
* leanprover-community/mathlib4#649
* leanprover-community/mathlib4#651
* leanprover-community/mathlib4#655
* leanprover-community/mathlib4#656
* leanprover-community/mathlib4#657
* leanprover-community/mathlib4#661
* leanprover-community/mathlib4#670
* leanprover-community/mathlib4#671
* leanprover-community/mathlib4#672
* leanprover-community/mathlib4#686
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 23, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17686)
1044429 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 24, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17686)
fe771af 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.inj_surj`: leanprover-community/mathlib4#707
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.group.units`: leanprover-community/mathlib4#549
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `data.ulift`: leanprover-community/mathlib4#703
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 25, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17686)
cb1d279 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.inj_surj`: leanprover-community/mathlib4#707
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.group.units`: leanprover-community/mathlib4#549
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.opposites`: leanprover-community/mathlib4#644
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `data.ulift`: leanprover-community/mathlib4#703
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-loreaux j-loreaux j-loreaux left review comments

@mcdoll mcdoll mcdoll left review comments

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@riccardobrasca @semorrison @j-loreaux @mcdoll @Ruben-VandeVelde