Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Port Data/Option/NAry.lean #656

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: Port Data/Option/NAry.lean #656

wants to merge 4 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Nov 19, 2022

Mathport pretty much got it right from the getgo, there is some things that can no longer be simp, but most importantly a defeq broke.

Mathlib sha 39af7d3bf61a98e928812dbc3e16f4ea8b795ca3

@ericrbg ericrbg added awaiting-review mathlib-port This is a port of a theory file from mathlib. labels Nov 19, 2022
@ericrbg ericrbg changed the title Port Data/Option/NAry.lean feat: Port Data/Option/NAry.lean Nov 19, 2022
mcdoll
mcdoll approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@mcdoll mcdoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Mathlib/Data/Option/NAry.lean Outdated Show resolved Hide resolved
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Nov 20, 2022
@ericrbg ericrbg added awaiting-review awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 20, 2022
This was referenced Nov 22, 2022
Closed
Closed
@semorrison
Copy link
Contributor

bors d+

Please update the port-status page when you merge. Thanks!

@bors
Copy link

bors bot commented Nov 23, 2022

✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ericrbg
Copy link
Collaborator Author

ericrbg commented Nov 23, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 23, 2022
@ericrbg
feat: Port Data/Option/NAry.lean (#656)
dceff8b 
Mathport pretty much got it right from the getgo, there is some things that can no longer be `simp`, but most importantly a defeq broke.

Mathlib sha 39af7d3bf61a98e928812dbc3e16f4ea8b795ca3


Co-authored-by: Eric Rodriguez <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Nov 23, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: Port Data/Option/NAry.lean [Merged by Bors] - feat: Port Data/Option/NAry.lean Nov 23, 2022
@bors bors bot closed this Nov 23, 2022
@bors bors bot deleted the ericrbg/try1 branch November 23, 2022 13:50
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 23, 2022
@eric-wieser
chore(*): add mathlibport comments (#17686)
4afb682 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* leanprover-community/mathlib4#643
* leanprover-community/mathlib4#646
* leanprover-community/mathlib4#648
* leanprover-community/mathlib4#649
* leanprover-community/mathlib4#651
* leanprover-community/mathlib4#655
* leanprover-community/mathlib4#656
* leanprover-community/mathlib4#657
* leanprover-community/mathlib4#661
* leanprover-community/mathlib4#670
* leanprover-community/mathlib4#671
* leanprover-community/mathlib4#672
* leanprover-community/mathlib4#686
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 23, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17686)
1044429 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 24, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17686)
fe771af 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.inj_surj`: leanprover-community/mathlib4#707
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.group.units`: leanprover-community/mathlib4#549
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `data.ulift`: leanprover-community/mathlib4#703
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 25, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17686)
cb1d279 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.inj_surj`: leanprover-community/mathlib4#707
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.group.units`: leanprover-community/mathlib4#549
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.opposites`: leanprover-community/mathlib4#644
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `data.ulift`: leanprover-community/mathlib4#703
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

@mcdoll mcdoll mcdoll approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericrbg @semorrison @mcdoll