Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port LazyList #686

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port LazyList #686

wants to merge 8 commits into from

Conversation

siddhartha-gadgil
Copy link
Collaborator

from commit c3019c79074b0619edb4b27553a91b2e82242395

@siddhartha-gadgil siddhartha-gadgil added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Nov 23, 2022
@siddhartha-gadgil siddhartha-gadgil changed the title Lazy list feat:port LazyList Nov 23, 2022
@siddhartha-gadgil siddhartha-gadgil mentioned this pull request Nov 23, 2022
Closed
@siddhartha-gadgil siddhartha-gadgil changed the title feat:port LazyList feat: port LazyList Nov 23, 2022
semorrison
semorrison reviewed Nov 23, 2022
View reviewed changes
Mathlib/Data/LazyList.lean Outdated
-/
unsafe def iterates (f : α → α) : α → LazyList α
| x => cons x (iterates f (f x))
-- #align lazy_list.iterates lazy_list.iterates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these commented out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting an error Declaration lazy_list.iterates not found with the suggestion of adding set_option align.precheck false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah: it needs to be #align lazy_list.iterates LazyList.iterates: it is correctly telling you that you mis-spelled the second argument!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will fix

@siddhartha-gadgil @semorrison
case correction
dadff65 
Co-authored-by: Scott Morrison <scott@tqft.net>
@semorrison
Copy link
Contributor

bors d+

after fixing the #aligns. Please update the port-status page after merging.

@bors
Copy link

bors bot commented Nov 23, 2022

✌️ siddhartha-gadgil can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Nov 23, 2022
@siddhartha-gadgil
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 23, 2022
@siddhartha-gadgil
feat: port LazyList (#686)
f08601a 
from commit c3019c79074b0619edb4b27553a91b2e82242395
@bors
Copy link

bors bot commented Nov 23, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port LazyList [Merged by Bors] - feat: port LazyList Nov 23, 2022
@bors bors bot closed this Nov 23, 2022
@bors bors bot deleted the lazy_list branch November 23, 2022 14:02
@github-actions github-actions bot mentioned this pull request Nov 23, 2022
Closed
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 23, 2022
@eric-wieser
chore(*): add mathlibport comments (#17686)
4afb682 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* leanprover-community/mathlib4#643
* leanprover-community/mathlib4#646
* leanprover-community/mathlib4#648
* leanprover-community/mathlib4#649
* leanprover-community/mathlib4#651
* leanprover-community/mathlib4#655
* leanprover-community/mathlib4#656
* leanprover-community/mathlib4#657
* leanprover-community/mathlib4#661
* leanprover-community/mathlib4#670
* leanprover-community/mathlib4#671
* leanprover-community/mathlib4#672
* leanprover-community/mathlib4#686
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 23, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17686)
1044429 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 24, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17686)
fe771af 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.inj_surj`: leanprover-community/mathlib4#707
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.group.units`: leanprover-community/mathlib4#549
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `data.ulift`: leanprover-community/mathlib4#703
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 25, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17686)
cb1d279 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.char_zero.defs`: leanprover-community/mathlib4#661
* `algebra.group.inj_surj`: leanprover-community/mathlib4#707
* `algebra.group.order_synonym`: leanprover-community/mathlib4#651
* `algebra.group.units`: leanprover-community/mathlib4#549
* `algebra.hierarchy_design`: leanprover-community/mathlib4#657
* `algebra.opposites`: leanprover-community/mathlib4#644
* `algebra.quotient`: leanprover-community/mathlib4#643
* `algebra.ring.defs`: leanprover-community/mathlib4#655
* `algebra.ring.order_synonym`: leanprover-community/mathlib4#671
* `control.equiv_functor`: leanprover-community/mathlib4#649
* `data.dlist.basic`: leanprover-community/mathlib4#616
* `data.int.cast.basic`: leanprover-community/mathlib4#670
* `data.lazy_list`: leanprover-community/mathlib4#686
* `data.list.lex`: leanprover-community/mathlib4#672
* `data.option.n_ary`: leanprover-community/mathlib4#656
* `data.sigma.lex`: leanprover-community/mathlib4#646
* `data.ulift`: leanprover-community/mathlib4#703
* `group_theory.eckmann_hilton`: leanprover-community/mathlib4#626
* `logic.equiv.basic`: leanprover-community/mathlib4#631
* `order.iterate`: leanprover-community/mathlib4#648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siddhartha-gadgil @semorrison