Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support info trees in AttrM #1350

Closed
digama0 opened this issue Jul 22, 2022 · 0 comments
Closed

Support info trees in AttrM #1350

digama0 opened this issue Jul 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@digama0
Copy link
Collaborator

digama0 commented Jul 22, 2022 •
edited
Loading

AFAICT this is blocking the ability to have go-to-definition (for things like @[implementedBy foo] or @[builtinTactic Parser.Tactic.focus]) or hovers (on either implementedBy or foo) on attributes.

I think this entails adding an infoState field and MonadInfoTree instance to AttrM (making it not just a copy of CoreM), and threading through the state in applyAttributesCore.
@gebner gebner added the enhancement New feature or request label Jul 22, 2022
leodemoura added a commit that referenced this issue Jul 25, 2022
@leodemoura
chore: move InfoTree.lean to src/Lean
1dfa2ae 
See #1350
leodemoura added a commit that referenced this issue Jul 25, 2022
@leodemoura
feat: add support for "jump-to-definition" at [implementedBy] attri…
f19b122 
…bute

see #1350
leodemoura added a commit that referenced this issue Jul 25, 2022
@leodemoura
feat: add support for "jump-to-definition" at [tactic ...], `[comma…
c042e7b 
…ndElab ...]` and `[termElab ...]` attributes

see #1350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gebner @digama0