Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: withLocation * should not fail if it closes the main goal #2917

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Nov 20, 2023

@leodemoura leodemoura removed the awaiting-review Waiting for someone to review the PR label Dec 1, 2023
@kim-em kim-em added the will-merge-soon …unless someone speaks up label Dec 11, 2023
@leodemoura leodemoura added this pull request to the merge queue Dec 12, 2023
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 12, 2023
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 12, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 12, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Merged via the queue into leanprover:master with commit 4b8c342 Dec 12, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants