chore: CI: in quick mode, only Nix build runs the tests #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following up on #2986, stop running the test suite in ci.yml in quick mode; the test suite is run in the Nix job, and we do not need to run it twice. With a cold nix cache, when `lean` is rebuilt, not much changes, as both jobs take ~20mins. But when `lean` is unchanged, the nix build should be faster, and shaving off the (currently) 4mins in the CI.yaml run should get us to a green PR sooner. Another benefit is that we get the PR release sooner and even get it when the test suite fails, which can be useful if you want to test mathlib or other things before fixing the lean test suite.
Kha
approved these changes
Nov 30, 2023
Kha
changed the title
github-actions
bot
added
the
toolchain-available
|
|
I promise I’ll try to write lowercase titles; but it goes very hard against my muscle memory. Maybe I’ll have to extend the commit convention check. |
nomeata
changed the title
|
Hah, I didn't even notice that this time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2986, stop running the test suite in ci.yml in quick
mode; the test suite is run in the Nix job, and we do not need to run it
twice.
With a cold nix cache, when
leanis rebuilt, not much changes, as bothjobs take ~20mins. But when
leanis unchanged, the nix build shouldbe faster, and shaving off the (currently) 4mins in the CI.yaml run
should get us to a green PR sooner.
Another benefit is that we get the PR release sooner and even get it
when the test suite fails, which can be useful if you want to test
mathlib or other things before fixing the lean test suite.