Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use structural recursion in Fin.induction #4010

Merged
merged 1 commit into from
Apr 28, 2024
Merged

feat: use structural recursion in Fin.induction #4010

merged 1 commit into from
Apr 28, 2024

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Apr 28, 2024

this should help with reducing mathlib's vector notation (![a,b,c] 2),
and reduce fallout from #4002

@nomeata
feat: use structural recursion in Fin.induction
27fb593 
this should help with reducing mathlib's vector notation (`![a,b,c] 2`),
and reduce fallout from #4002
@nomeata nomeata force-pushed the joachim/fin-induction-structural branch from 82e154f to 27fb593 Compare April 28, 2024 15:38
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 28, 2024 15:53 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 28, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 28, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4010
3dcc69e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 28, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4010
cc325e3
@nomeata
Copy link
Contributor Author

nomeata commented Apr 28, 2024

Mathlib perf impact (nothing exciting to see): http://speed.lean-fro.org/mathlib4/compare/d444b71b-0228-43f5-951d-975ddabbc565/to/f1d3f7dd-931f-4250-9a10-263dbc927957

@nomeata nomeata marked this pull request as ready for review April 28, 2024 16:50
@nomeata nomeata requested a review from kim-em as a code owner April 28, 2024 16:50
@nomeata nomeata added the will-merge-soon …unless someone speaks up label Apr 28, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 28, 2024 16:53 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 28, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4010
45610d9
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 28, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4010
487daae
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Apr 28, 2024 •
edited
Loading

Mathlib CI status (docs):

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Apr 28, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 28, 2024 17:35 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Apr 28, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4010
20124e4
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 28, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4010
40a72ec
@nomeata nomeata added this pull request to the merge queue Apr 28, 2024
Merged via the queue into master with commit f817d5a Apr 28, 2024
27 checks passed
@nomeata nomeata deleted the joachim/fin-induction-structural branch April 29, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura leodemoura approved these changes

@kim-em kim-em Awaiting requested review from kim-em

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nomeata @leanprover-community-mathlib4-bot @leodemoura