Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rw should not include existing goal metavariables in the resulting subgoals #4385

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix: rw should not include existing goal metavariables in the resulting subgoals #4385

merged 2 commits into from
Jun 11, 2024

Conversation

leodemoura
Copy link
Member

closes #4381

@leodemoura leodemoura mentioned this pull request Jun 6, 2024
Closed
@leodemoura leodemoura changed the title fix: rw should not include existing metavariables in the resulting subgoals fix: rw should not include existing goal metavariables in the resulting subgoals Jun 6, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 6, 2024 22:44 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 6, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 6, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4385
b7295b1
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 6, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4385
5487a61
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan release-ci Enable all CI checks for a PR, like is done for releases labels Jun 6, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Jun 6, 2024 •
edited
Loading

Mathlib CI status (docs):

@JovanGerb
Copy link
Contributor

In your fix, the otherMVarIds now come from heq, and this is created using let heq := mkAppN heq newMVars. But these newMVars are already taken into account in newMVarIds. And in the Iff case, we get let heq := mkApp3 (mkConst `propext) lhs rhs heq, so then we will suddenly get metavariables from lhs and rhs. Would it be better to define otherMVarIds to be the metavariables in the original heq that was passed as an argument to rewrite?

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 7, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4385
bf56c27
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 7, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4385
5fed1cf
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 7, 2024 02:04 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 7, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4385
4dd0740
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 7, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4385
cfd4c1a
@leodemoura
Copy link
Member Author

@semorrison Could you please take a look at the Mathlib failures?

@kim-em
Copy link
Collaborator

kim-em commented Jun 10, 2024

@semorrison Could you please take a look at the Mathlib failures?

Looking now.

@kim-em
Copy link
Collaborator

kim-em commented Jun 11, 2024

All the changes in Mathlib are positive! (I'm surprised more people weren't complaining about their goals being stolen!)

@kim-em kim-em added this pull request to the merge queue Jun 11, 2024
Merged via the queue into master with commit ec775df Jun 11, 2024
22 checks passed
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Jun 11, 2024
@kim-em kim-em deleted the issue_4381 branch June 11, 2024 03:37
@kim-em kim-em mentioned this pull request Jun 13, 2024
Merged
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 16, 2024
@kim-em @jcommelin
chore: adaptations for nightly-2024-06-12 (#13811)
12f0f6e 
This includes adaptations for:

* leanprover/lean4#4430
* leanprover/lean4#4421
* leanprover/lean4#4357
* leanprover/lean4#4385
* leanprover/lean4#4408

Sorry that it's a few days worth in one go, for various reasons it was
hard to get to green during this period.

---------

Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rw duplicates goals for metavariables appearing in the rewritten expression
4 participants
@leodemoura @leanprover-community-mathlib4-bot @JovanGerb @kim-em