Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Replacement.apply #4776

Merged
merged 2 commits into from
Jul 17, 2024
Merged

perf: Replacement.apply #4776

merged 2 commits into from
Jul 17, 2024

Conversation

leodemoura
Copy link
Member

Avoid potentially expensive e.replace if it is not applicable.

Avoid potentially expensive `e.replace` if it is not applicable.
@leodemoura
Copy link
Member Author

!bench

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 17, 2024 16:12 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 17, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 8e396068e4986ad2988dc014d20dc0823d5a8569 --onto 7aec6c9ae7a54935ada0df0b4cc1efafc2291007. (2024-07-17 16:13:39)

@leodemoura leodemoura added this pull request to the merge queue Jul 17, 2024
Merged via the queue into master with commit 41b4914 Jul 17, 2024
13 checks passed
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit c272ee2.
There were significant changes against commit 8e39606:

  Benchmark   Metric             Change
  ===============================================
- stdlib      fix level params     3.1% (990.6 σ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants