Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make pretty printer escape identifiers that are tokens #4979

Merged
merged 4 commits into from
Sep 7, 2024
Merged

fix: make pretty printer escape identifiers that are tokens #4979

merged 4 commits into from
Sep 7, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Aug 10, 2024

For example, if forall is a variable, it now pretty prints as «forall».

Closes #4686

@kmill kmill requested a review from Kha as a code owner August 10, 2024 21:43
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 10, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 10, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4979
305113a
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Aug 10, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4979
74842f7
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 10, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4979
53b2c0f
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Aug 10, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4979
c812cf8
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Aug 10, 2024 •
edited
Loading

Mathlib CI status (docs):

  • 🟡 Mathlib branch lean-pr-testing-4979 build against this PR was cancelled. (2024-08-10 22:21:34) View Log
  • ✅ Mathlib branch lean-pr-testing-4979 has successfully built against this PR. (2024-08-10 23:22:10) View Log
  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-09-07 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-09-07 21:28:13)

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Aug 10, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 11, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4979
945cfda
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Aug 11, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4979
edae3d2
@kmill kmill enabled auto-merge September 7, 2024 21:11
@kmill kmill added this pull request to the merge queue Sep 7, 2024
Merged via the queue into leanprover:master with commit 8fcec40 Sep 7, 2024
13 checks passed
tobiasgrosser pushed a commit to opencompl/lean4 that referenced this pull request Sep 16, 2024
@kmill @tobiasgrosser
fix: make pretty printer escape identifiers that are tokens (leanprov…
5ab1191 
…er#4979)

For example, if `forall` is a variable, it now pretty prints as
`«forall»`.

Closes leanprover#4686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kha Kha Awaiting requested review from Kha Kha is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identifier pretty-printing can clash with notation
2 participants
@kmill @leanprover-community-mathlib4-bot