Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include identifier before cursor in document highlight request #5237

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

mhuisi
Copy link
Contributor

@mhuisi mhuisi commented Sep 2, 2024

Fixes #3023. Also fixes a similar off-by-one in the file worker definition request.

The watchdog definition request already does this correctly, but when the request falls through to the file worker, it wouldn't use the identifier before the cursor.
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 2, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 830b1191b375240abb85b4c34310969f28855754 --onto d31066646dfa7389d818a2e2e1493be6a941924e. (2024-09-02 15:14:33)

@mhuisi mhuisi added this pull request to the merge queue Sep 4, 2024
Merged via the queue into leanprover:master with commit d55f55d Sep 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document highlight should include identifiers just before cursor
2 participants