Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: travelling auto-completion #5257

Merged
merged 4 commits into from
Sep 10, 2024
Merged

fix: travelling auto-completion #5257

merged 4 commits into from
Sep 10, 2024

Conversation

mhuisi
Copy link
Contributor

@mhuisi mhuisi commented Sep 4, 2024 •
edited
Loading

Fixes #4455, fixes #4705, fixes #5219

Also fixes a minor bug where a dot in brackets would report incorrect completions instead of no completions.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 4, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Sep 4, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 5c61ad38bec18056d97a7a0319af180fc3b3b703 --onto 66688e10ceef553f48b935a74d9bbd096edf96f5. (2024-09-04 08:23:26)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 5c61ad38bec18056d97a7a0319af180fc3b3b703 --onto 1b099521c1bfd5fbcbb90808396b767f0bb3e661. (2024-09-06 12:46:24)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 5c61ad38bec18056d97a7a0319af180fc3b3b703 --onto c96fbdda44c14c7c256f046fb2b71fae25ea968e. (2024-09-09 10:00:35)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase ab7aed29308351daf4b7c35216d6033aa33c0a6c --onto c96fbdda44c14c7c256f046fb2b71fae25ea968e. (2024-09-09 12:54:56)

mhuisi and others added 4 commits September 9, 2024 14:36
@mhuisi
fix: travelling auto-completions
d108e02 
This breaks pipe auto-completion because of an elaborator bug.
@mhuisi
test: travelling completions
89bacd9
@mhuisi @Kha
fix: retain SourceInfo in pipeProj elaborator
dddb577 
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
@mhuisi
fix: don't use id completion for expected type dot
b3cd3d2
@mhuisi mhuisi marked this pull request as ready for review September 9, 2024 12:45
@mhuisi mhuisi added this pull request to the merge queue Sep 10, 2024
Merged via the queue into leanprover:master with commit a58520d Sep 10, 2024
14 checks passed
tobiasgrosser pushed a commit to opencompl/lean4 that referenced this pull request Sep 16, 2024
@mhuisi @Kha @tobiasgrosser
fix: travelling auto-completion (leanprover#5257)
cc95a80 
Fixes leanprover#4455, fixes leanprover#4705, fixes leanprover#5219

Also fixes a minor bug where a dot in brackets would report incorrect
completions instead of no completions.

---------

Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autocomplete failure Unexpected field notation completion a code suggestion bug
2 participants
@mhuisi @leanprover-community-mathlib4-bot