-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support at
in ac_nf
and use it in bv_normalize
#5618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasgrosser
force-pushed
the
ac_nf_on_hypothesis2
branch
from
October 4, 2024 13:19
d8ac2e1
to
7a42a3e
Compare
... while at it also call `trivial` to close goals that can be trivially closed.
tobiasgrosser
force-pushed
the
ac_nf_on_hypothesis2
branch
from
October 4, 2024 13:20
7a42a3e
to
074f964
Compare
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Oct 4, 2024
Mathlib CI status (docs):
|
bollu
reviewed
Oct 4, 2024
tobiasgrosser
changed the title
feat: support
feat: support Oct 5, 2024
at
in ac_nfat
in ac_nf and use it in bv_normalize
hargoniX
requested changes
Oct 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks fine apart from this, remaingin TODOs:
- change bv_ test cases so that goals that are now trivially solved by
ac_nf
are expanded upon with new tests that keep stressing the bitblaster on the same operations - fix already existing test cases
Co-authored-by: Henrik Böving <hargonix@gmail.com>
tobiasgrosser
changed the title
feat: support
feat: support Oct 5, 2024
at
in ac_nf and use it in bv_normalizeat
in ac_nf
and use it in bv_normalize
hargoniX
approved these changes
Oct 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will wait until CI issues are resolved to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
will-merge-soon
…unless someone speaks up
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... while at it also call
trivial
to close goals that can be trivially closed.