Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support at in ac_nf and use it in bv_normalize #5618

Merged
merged 24 commits into from
Oct 7, 2024

Conversation

tobiasgrosser
Copy link
Contributor

@tobiasgrosser tobiasgrosser commented Oct 4, 2024

... while at it also call trivial to close goals that can be trivially closed.

... while at it also call `trivial` to close goals that can be trivially closed.
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 4, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f9048c132d381dfbefe581983d5a93d96c147300 --onto a4fda010f3d44c02393d5afd5cf05509989daf63. (2024-10-04 13:39:37)

@tobiasgrosser tobiasgrosser marked this pull request as draft October 5, 2024 07:43
@tobiasgrosser tobiasgrosser changed the title feat: support at in ac_nf feat: support at in ac_nf and use it in bv_normalize Oct 5, 2024
Copy link
Contributor

@hargoniX hargoniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks fine apart from this, remaingin TODOs:

  • change bv_ test cases so that goals that are now trivially solved by ac_nf are expanded upon with new tests that keep stressing the bitblaster on the same operations
  • fix already existing test cases

src/Lean/Elab/Tactic/BVDecide/Frontend/Normalize.lean Outdated Show resolved Hide resolved
src/Lean/Meta/Tactic/AC/Main.lean Show resolved Hide resolved
src/Lean/Meta/Tactic/AC/Main.lean Outdated Show resolved Hide resolved
@tobiasgrosser tobiasgrosser marked this pull request as ready for review October 5, 2024 19:12
@tobiasgrosser tobiasgrosser changed the title feat: support at in ac_nf and use it in bv_normalize feat: support at in ac_nf and use it in bv_normalize Oct 5, 2024
Copy link
Contributor

@hargoniX hargoniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait until CI issues are resolved to merge.

@hargoniX hargoniX added the will-merge-soon …unless someone speaks up label Oct 5, 2024
@hargoniX hargoniX added this pull request to the merge queue Oct 7, 2024
Merged via the queue into leanprover:master with commit c0617da Oct 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants