Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix elan install error handling on windows. #157

Merged
merged 10 commits into from
Mar 22, 2022
Merged

fix elan install error handling on windows. #157

merged 10 commits into from
Mar 22, 2022

Conversation

lovettchris
Copy link
Contributor

Dependent on leanprover/elan#63

@lovettchris lovettchris mentioned this pull request Mar 19, 2022
Merged
@Kha
Copy link
Member

Kha commented Mar 19, 2022

I'll merge the elan PR if this part looks good too

@lovettchris
Copy link
Contributor Author

I'll merge the elan PR if this part looks good too

Thanks, when you merge the elan PR I'll switch the leanInstallerWindows path back and test the official version... I fixed the elan Test that was using the old leanpkg which is now gone, I switched it to use lake.

@gebner
Copy link
Member

gebner commented Mar 21, 2022

Looks good to me.

@lovettchris lovettchris mentioned this pull request Mar 21, 2022
Merged
3 tasks
@lovettchris lovettchris mentioned this pull request Mar 21, 2022
Merged
@Vtec234 Vtec234 merged commit e059f9f into master Mar 22, 2022
@lovettchris lovettchris deleted the clovett/noprompt branch March 22, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lovettchris @Kha @gebner @Vtec234