getEntitiesToIndex() now returns an iterable

leapt · Jan 14, 2020 · 54b2125 · 54b2125
1 parent 0256e4b
commit 54b2125
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/src/Indexer/IndexerInterface.php b/src/Indexer/IndexerInterface.php
@@ -52,12 +52,12 @@ public function getMappings(): array;
     public function getIndexAction($entity, Type $type): string;
 
     /**
-     * Return an array of all the entities that need to be reindexed
+     * Return an iterable of all the entities that need to be reindexed
      * during a rebuild operation.
      *
      * @abstract
      */
-    public function getEntitiesToIndex(EntityManager $em, Type $type): array;
+    public function getEntitiesToIndex(EntityManager $em, Type $type): iterable;
 
     /**
      * Get the entities to index provided a given entity

diff --git a/src/Service.php b/src/Service.php
@@ -111,8 +111,7 @@ public function rebuildType($typeName)
             $mapping->send();
 
             // Reindex data
-            $entities = $indexer->getEntitiesToIndex($this->container->get('doctrine.orm.entity_manager'), $type);
-            foreach ($entities as $entity) {
+            foreach ($indexer->getEntitiesToIndex($this->container->get('doctrine.orm.entity_manager'), $type) as $entity) {
                 $indexer->addIndex($entity, $type);
             }
             $this->container->get('doctrine.orm.entity_manager')->clear();

diff --git a/tests/Listener/Mock/FooIndexer.php b/tests/Listener/Mock/FooIndexer.php
@@ -36,7 +36,7 @@ public function getIndexAction($entity, Type $type): string
         return '';
     }
 
-    public function getEntitiesToIndex(EntityManager $em, Type $type): array
+    public function getEntitiesToIndex(EntityManager $em, Type $type): iterable
     {
         return [];
     }

diff --git a/tests/Mock/BarIndexer.php b/tests/Mock/BarIndexer.php
@@ -31,7 +31,7 @@ public function getIndexAction($entity, Type $type): string
         return '';
     }
 
-    public function getEntitiesToIndex(EntityManager $em, Type $type): array
+    public function getEntitiesToIndex(EntityManager $em, Type $type): iterable
     {
         return [];
     }

diff --git a/tests/Mock/FooIndexer.php b/tests/Mock/FooIndexer.php
@@ -31,7 +31,7 @@ public function getIndexAction($entity, Type $type): string
         return '';
     }
 
-    public function getEntitiesToIndex(EntityManager $em, Type $type): array
+    public function getEntitiesToIndex(EntityManager $em, Type $type): iterable
     {
         return [];
     }