This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Find active editor through atom on save #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see learn-co/learn-ide#425
should be released with learn-ide@2.5.0
While working on this, I also discovered that line endings were causing trouble with save on Windows. Basically, we switch to LF from CRLF before sending a file to the server, and it is then sent back to the local disk in LF; however, the buffer still thinks it should be CRLF, so the file stays "dirty" (looks like it hasn't saved). This now updates the contents of the buffer before sending the file to the server, so that as soon as it gets back, the text buffer will recognize that it is in sync with the disk contents.