Spruce up UI for curriculum app #76
Comments
|
[Comment from Clubhouse user @Tanner:] @jaredatron: mind if I take a crack at this? |
|
[Comment from Clubhouse user @jaredatron:] not at all. @jeffreywescott and I talked about picking a CSS framework that works with both react and non-react (bootstrap, material-ui, ?) and then building a shared LG theme. That way we can all use the same assets across all of our apps. Maybe in a shared npm repo or something. So maybe we should start there? |
|
[Comment from Clubhouse user @prattsj:] +1 to using an existing material design react ui library (and really a ui library rather than just a css framework) and creating a custom css theme for it. would make a request that we not use material-ui, though. i've used it extensively in the past (back when it was the only decent one out there). its performance is terrible and it's difficult to do theming. https://www.reddit.com/r/reactjs/comments/4fd4ro/materialui_vs_reacttoolbox_and_why/ we're using react-toolbox for echo and, while it has some shortcomings, its performance is good and it's much easier to work with and customize. i like jared's idea of having a module on npm - we can basically just have a wrapper around whatever ui library we choose. |
|
[Comment from Clubhouse user @prattsj:] sure. i mean...react-toolbox uses css modules, so i see an opportunity for us to actually have 2 separate repos: one for the s/css, then another that depends on that and wraps react-toolbox (plus other custom) react components in it. |
|
[Comment from Clubhouse user @prattsj:] another option is materialize: http://materializecss.com |
|
is this a duplicate of issue #74 ? |
|
Ok so a first pass is ready for review here: #91. It's not perfect, but I didn't want to spend too much time customizing the bootflat styles if we will be merging curriculum soon anyway. |
|
@jeffreywescott why do we have to use the standard favicon. That seems like form over function. I want to be able to distinguish between tabs more easily. |
|
Iif we had an "on brand" favicon that clearly communicated Learners Guild while also communicating the specific app, we would consider it. But brand trumps ugly icons in this case. |
|
who decides what is ugly?
…On Wed, Jul 12, 2017 at 9:59 AM, Jeffrey Wescott ***@***.***> wrote:
Iif we had an "on brand" favicon that clearly communicated Learners Guild
while also communicating the specific app, we would consider it. But brand
trumps ugly icons in this case.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAgwWif2Kmxc3uxBp3InTtqDr_2CzEtks5sNPtYgaJpZM4OTRo3>
.
|
(merged two stories to create this one)
From ch3847
Some simple design tweaks we could do:
From ch3403
Description
colors
We need to ensure that the branding (colors, mostly) align with the Guild branding guide.
favicon
We should always use the Learners Guild icon for favicons for all services. This was a Q1 goal of "internal brand matching external brand".
Side-note: Please don't create new iconography in any of our services!
Details
The "right" way to do it (that works on all devices in a seamless way) is to do something like IDM does by downloading the
<head>metadata as necessary frombrand.learnersguild.org.Check out
npm run icons:fetchon IDM.Tasks
The text was updated successfully, but these errors were encountered: