Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging in Jupyter and Colab #542

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fix logging in Jupyter and Colab #542

merged 1 commit into from
Jan 3, 2023

Conversation

borzunov
Copy link
Member

@borzunov borzunov commented Jan 3, 2023

This PR:

  • Enables colors in Jupyter and Colab
  • Makes it possible to enable/disable logging colors on the fly
  • Addresses the issue with duplicate log lines on Colab in case of use_hivemind_log_handler("in_root_logger")

Now:

Screenshot 2023-01-03 at 16 30 54

Before this PR, we'd have non-colored duplicated lines.

Based on bigscience-workshop/petals#156, but this code should be in hivemind, not petals.

@borzunov borzunov changed the title Enable colors in Jupyter and Colab Fix logging in Jupyter and Colab Jan 3, 2023
@borzunov borzunov merged commit 9d39fea into master Jan 3, 2023
@borzunov borzunov deleted the colors-in-colab branch January 3, 2023 12:35
mryab pushed a commit that referenced this pull request Jan 7, 2023
This PR:

- Enables colors in Jupyter and Colab
- Makes it possible to enable/disable logging colors on the fly
- Addresses the issue with duplicate log lines on Colab in case of `use_hivemind_log_handler("in_root_logger")`

(cherry picked from commit 9d39fea)
borzunov added a commit to bigscience-workshop/petals that referenced this pull request May 7, 2023
borzunov added a commit to bigscience-workshop/petals that referenced this pull request May 7, 2023
This PR:

1. Updates hivemind to 1.1.8 (includes learning-at-home/hivemind#565)
2. Enables efficient bfloat16 serialization by default (`USE_LEGACY_BFLOAT16 = False`)
3. Removes logging code that was included to hivemind in learning-at-home/hivemind#542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants