Merge pull request #5222 from benjaoming/fix-uid-check

test getuid() == 0 instead of arbitrary 502
learningequality · Jul 28, 2016 · 6954468 · 6954468
2 parents 4e1e996 + 82637c5
commit 6954468
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/kalite/distributed/management/commands/setup.py b/kalite/distributed/management/commands/setup.py
@@ -257,11 +257,8 @@ def handle(self, *args, **options):
                 "--------------------------------------------------------------------------------")
             raw_input("Press [enter] to continue...")
 
-        # Tried not to be os-specific, but ... hey. :-/
-        # benjaoming: This doesn't work, why is 502 hard coded!? Root is normally
-        # '0' And let's not care about stuff like this, people can be free to
-        # run this as root if they want :)
-        if not is_windows() and hasattr(os, "getuid") and os.getuid() == 502:
+        # Assuming uid '0' is always root
+        if not is_windows() and hasattr(os, "getuid") and os.getuid() == 0:
             print(
                 "-------------------------------------------------------------------")
             print("WARNING: You are installing KA-Lite as root user!")