New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coach reports: Apply date rage to tabular report #5022

Closed
harishbalachandran opened this Issue Mar 21, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@harishbalachandran

harishbalachandran commented Mar 21, 2016

Detailed description:
For the date range selected total exercise attempted is shown as 7, but the tabular column shows all the exercise of the all the kids instead of the selected date range.

Expected behavior:
Only the 7 exercise should be displayed on the column so that its easy for the teachers to see the progress made by the kids on a selected date range.

Actual behavior:
All the exercise are getting displayed for all the kids even though the selected date range shows total attempted exercise as 7. This is a huge problem for the teacher who has to scroll through all the exercise and is very time consuming.
screen shot 2016-03-21 at 6 44 31 pm
screen shot 2016-03-21 at 6 45 13 pm
screen shot 2016-03-21 at 6 44 50 pm
screen shot 2016-03-21 at 6 44 56 pm
screen shot 2016-03-21 at 6 45 03 pm

Please refer the screenshots for more details.

@sethachoi

This comment has been minimized.

Show comment
Hide comment
@sethachoi

sethachoi Mar 25, 2016

Contributor

Currently true as of 0.16.x

Date filter does not filter which student's did the exercises/videos in the selected timespan. Instead, it just shows everyone who has done the exercise (date picker has no effect on who is shown on the tabular view)

Contributor

sethachoi commented Mar 25, 2016

Currently true as of 0.16.x

Date filter does not filter which student's did the exercises/videos in the selected timespan. Instead, it just shows everyone who has done the exercise (date picker has no effect on who is shown on the tabular view)

@harishbalachandran

This comment has been minimized.

Show comment
Hide comment
@harishbalachandran

harishbalachandran Mar 25, 2016

I understand that the date filter does not have effect on the student list and all the students names are displayed row wise.

But shouldn't date filter do the work of filtering out the topics attempted during that time period?

In the screen shot above for the date filter 3/21/2016, there were only 7 exercises attempted, so shouldn't only those exercise attempted displayed on the column instead of all the exercises?

Please confirm my understanding.

harishbalachandran commented Mar 25, 2016

I understand that the date filter does not have effect on the student list and all the students names are displayed row wise.

But shouldn't date filter do the work of filtering out the topics attempted during that time period?

In the screen shot above for the date filter 3/21/2016, there were only 7 exercises attempted, so shouldn't only those exercise attempted displayed on the column instead of all the exercises?

Please confirm my understanding.

@sethachoi

This comment has been minimized.

Show comment
Hide comment
@sethachoi

sethachoi Mar 25, 2016

Contributor

Sorry if that was unclear, I was just confirming the bug was present on our 0.16 version rather than just being in the 0.15 version.

Contributor

sethachoi commented Mar 25, 2016

Sorry if that was unclear, I was just confirming the bug was present on our 0.16 version rather than just being in the 0.15 version.

@harishbalachandran

This comment has been minimized.

Show comment
Hide comment
@harishbalachandran

harishbalachandran Mar 25, 2016

Thanks once again for the clarification 👍

harishbalachandran commented Mar 25, 2016

Thanks once again for the clarification 👍

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles Mar 26, 2016

Member

I think mostly this is an issue with generaterealdata rather than the coach reports - it seems to be generating way more exerciselogs than attemptlogs, hence giving the erroneous output.

It did however make me catch one small error with the date ranging for the tabular report.

Member

rtibbles commented Mar 26, 2016

I think mostly this is an issue with generaterealdata rather than the coach reports - it seems to be generating way more exerciselogs than attemptlogs, hence giving the erroneous output.

It did however make me catch one small error with the date ranging for the tabular report.

@rtibbles rtibbles self-assigned this Mar 26, 2016

@rtibbles rtibbles changed the title from Total Exercise attempted should only be shown for the date range selected on the coach report - Version 0.15 to Total Exercise attempted should only be shown for the date range selected on the coach report - Version 0.15 Mar 26, 2016

@rtibbles rtibbles added the has PR label Mar 26, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 1, 2016

Member

@harishbalachandran are you around to triage if this is still present? generaterealdata has been fixed in #4288

Member

benjaoming commented Aug 1, 2016

@harishbalachandran are you around to triage if this is still present? generaterealdata has been fixed in #4288

@benjaoming benjaoming added this to the 0.17.0 milestone Aug 1, 2016

@benjaoming benjaoming modified the milestones: 0.17.0, 0.17.1 Mar 19, 2017

@benjaoming benjaoming changed the title from Total Exercise attempted should only be shown for the date range selected on the coach report - Version 0.15 to Coach reports: Apply date rage to tabular report Apr 7, 2017

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Apr 7, 2017

Member

In kalite/coachreports/static/js/coachreports/tabular_reports/views.js, we are correctly retrieving start_date and end_date, however it seems to be a different instance of this.model that isn't affected by events in TimeSetView.set_range.

        this.data_model = new Models.CoachReportModel({
            facility: this.model.get("facility"),
            group: this.model.get("group"),
            start_date: date_string(this.model.get("start_date")),
            end_date: date_string(this.model.get("end_date")),
            topic_ids: this.model.get("topic_ids")
        });
Member

benjaoming commented Apr 7, 2017

In kalite/coachreports/static/js/coachreports/tabular_reports/views.js, we are correctly retrieving start_date and end_date, however it seems to be a different instance of this.model that isn't affected by events in TimeSetView.set_range.

        this.data_model = new Models.CoachReportModel({
            facility: this.model.get("facility"),
            group: this.model.get("group"),
            start_date: date_string(this.model.get("start_date")),
            end_date: date_string(this.model.get("end_date")),
            topic_ids: this.model.get("topic_ids")
        });
@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Apr 7, 2017

Member

Fixed in #5435

Member

benjaoming commented Apr 7, 2017

Fixed in #5435

@benjaoming benjaoming closed this Apr 7, 2017

@benjaoming benjaoming removed the has PR label Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment