Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrading requests causes issues with old versions of pip #5264

Closed
mrpau-eduard opened this issue Aug 29, 2016 · 3 comments
Closed

Downgrading requests causes issues with old versions of pip #5264

mrpau-eduard opened this issue Aug 29, 2016 · 3 comments
Labels
Milestone

Comments

@mrpau-eduard
Copy link
Contributor

mrpau-eduard commented Aug 29, 2016

Summary

Edit: @benjaoming

The downgrading of requests causes issues with pip both system-wide and inside virtualenvs (in which, however, pip isn't needed unless user installs additional pkgs from PyPi)

This is known to affect older versions of pip, 1.5.6 especially

The fix will arrive in 0.17.


The original issue here is we downgrade requests to fix the Unclean shutdown on OS X.
Spawn issue after the downgrade Ka-lite installed with PIP break the latter.

System information

  • Operating system: OS X, Debian Jessie
  • Version: 0.16.

Real-life consequences (anything community should be aware, for instance how it affects your deployment)

@mrpau-eduard
Copy link
Contributor Author

We need to replace Pyrun by PEX base on the spawning issue. PEX will isolate the virtual environment for ka-lite to prevent some issue like this. Then we need upgrade the requests to requests==2.10.0

@benjaoming
Copy link
Contributor

@mrpau-eduard - it's unclear to me what the issue on Debian Jessie is?

But I agree, we need to get requests upgraded ASAP because of the pip breakage.

@benjaoming benjaoming changed the title Downgrading requests having an issue on Debian Jessie Downgrading requests causes issues with pip Sep 5, 2016
@benjaoming benjaoming changed the title Downgrading requests causes issues with pip Downgrading requests causes issues with old versions of pip Sep 5, 2016
@benjaoming benjaoming added the bug label Sep 5, 2016
@benjaoming benjaoming added this to the 0.17.0 milestone Sep 5, 2016
@benjaoming
Copy link
Contributor

Fixed in #5285

requests is now in version 2.11.1 in develop, will be released in 0.17 - prereleased in 0.17b1 on PyPi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants