make sure the language-specific i18n js catalog file is loaded before en.js. #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en.js. Or else, we get english catalog files, i.e. it won't get translated.
|
Merging this now, as the changes seem harmless*.
|
aronasorman
added a commit
that referenced
this pull request
Jul 28, 2015
make sure the language-specific i18n js catalog file is loaded before en.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or else, we get english catalog files, i.e. it won't get translated.
Also added a few more gettext calls in the coachreports JS.
Assigned you @rtibbles since I moved en.js out of the compress block. Aside from a slightly longer asset loading process, are there any other implications?