Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow-up issue] Setup Wizard - Validation messages at 'Import individual user accounts' and 'Use an admin account' #11711

Closed
pcenov opened this issue Jan 10, 2024 · 4 comments
Assignees
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: backend Python, databases, networking, filesystem... DEV: frontend P1 - important Priority: High impact on UX

Comments

@pcenov
Copy link
Member

pcenov commented Jan 10, 2024

Observed behavior

While regression testing #11704 I noticed the following additional minor validation related issues:

  • there's no error message displayed if the user attempts to submit an empty form (that's valid both at 'Import individual user accounts' and 'Use an admin account')
  • when we have only the 'Username' field being displayed and I enter an admin username then I am still seeing the "Incorrect username or password" - I think in that case we should be showing the Device limitations modal, the same as when the Password field is visible
  • if after seeing the "Incorrect username or password" message I click the Use an admin account link then the "Incorrect username or password" message is still being displayed above the empty form for the admin credentials
  • when we have both the Username and Password fields displayed and I enter the username of a learner who was originally created without a password then it's not accepted as valid credentials and I have to import that learner signed in as an admin. This is probably OK, but just mentioning it here as an edge case in case that could be considered.

Expected behavior

The issues should be further discussed and either fixed with separate PRs or disregarded.

Steps to reproduce the issue

  1. Install the latest Beta 10 build asset.
  2. In the setup wizard go through Group learning > Learn-only device > Import one or more existing user accounts from an existing facility
  3. At the Import individual user accounts you will either see only the 'Username' field or both the 'Username' and 'Password' fields if the option 'Require passwords for learners' checkbox is selected at Device > Settings on the server.

Usage Details

Beta 10
Ubuntu 22 - Chrome

@pcenov
Copy link
Member Author

pcenov commented Jan 10, 2024

@marcellamaki

@GarvitSinghal47
Copy link
Contributor

If all the above-mentioned issues are available for assignment, I would like to work on them. @MisRob

@radinamatic radinamatic added P1 - important Priority: High impact on UX DEV: backend Python, databases, networking, filesystem... APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend labels Jan 22, 2024
@jredrejo jredrejo self-assigned this Jan 22, 2024
@MisRob
Copy link
Member

MisRob commented Jan 23, 2024

Hi @GarvitSinghal47, thank you for volunteering here. This one is assigned to @jredrejo already.

@jredrejo
Copy link
Member

jredrejo commented Feb 5, 2024

Fixed in #11807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: backend Python, databases, networking, filesystem... DEV: frontend P1 - important Priority: High impact on UX
Projects
None yet
Development

No branches or pull requests

6 participants