-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture more errors from the backend and show error messages for them #11807
Capture more errors from the backend and show error messages for them #11807
Conversation
Build Artifacts
|
I think this is correct, and only allowing to do this on the Kolibri device the user is on and not remotely seems more secure. |
Hi @jredrejo while regression testing the import of individual user accounts I noticed that now if I select the 'Use an admin account' option, when I click the 'Back' arrow then I am brought back to the 'Import individual user accounts' page and I can't proceed because now the 'Username' and 'Password' fields are required. Here's a video of what I am doing: 2024-01-29_18-28-18.mp4 |
@pcenov fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jredrejo - manual QA passes, good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes make sense, manual QA checks out. @marcellamaki I suspect we should merge this for 0.16.0.
6008a25
into
learningequality:release-v0.16.x
Summary
In the wizard setup, when importing users from a remote facility
References
Closes #11711
In reference to #11711 , the last point of the description:
has not being changed as it seems a correct behaviour of the application. When facility settings are changed, previous user not requiring a password to login can't login until they have a password. Importing them remotely should not be different. In any case, if @jtamiace has a better solution, perfect.
Reviewer guidance
Follow the steps @pcenov described in #11711
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)