Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading spinner misalignment #11884

Closed
marcellamaki opened this issue Feb 15, 2024 · 5 comments
Closed

Loading spinner misalignment #11884

marcellamaki opened this issue Feb 15, 2024 · 5 comments
Assignees
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P1 - important Priority: High impact on UX

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Feb 15, 2024

Observed behavior

There are a couple of places where the KCircularLoader spinner is misaligned to the text that it should be next to

Incorrect display

Sync status display
statusdisplay2

On the downloads page:
image (24)

Expected behavior

  • The KCircularLoader should be sized proportionally to the text
  • The loader should be in line with the text, and the items should be alined horizontally

Example of proper scale and alignment:
Screenshot 2024-02-15 at 12 58 10 PM

Steps to reproduce

  1. Set up two Kolibris - one as a Learn Only Device (LOD) and one as a full facility. The LOD should be set up to sync back the main facility
  2. Assign some resources to the Learner
  3. Observe the sync status

Part 2:

  1. Set up Kolibri as an "on my own" setup
  2. download some content from the Kolibri Content Library via your internet connection by browsing the library page
  3. go to "my downloads" and observe the syncing display and spinner

Note: modifying your connection speed to "Slow 3G" in the browser may help with replicating a slower download so the loading/waiting state can be properly observed

Context

Kolibri v0.16.x

@marcellamaki marcellamaki added P1 - important Priority: High impact on UX DEV: frontend help wanted Open source contributors welcome labels Feb 15, 2024
@marcellamaki marcellamaki added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) and removed APP: Learn Re: Learn App (content, quizzes, lessons, etc.) labels Feb 15, 2024
@MisRob MisRob added the good first issue Self-contained, straightforward, low-complexity label Feb 16, 2024
@MisRob
Copy link
Member

MisRob commented Feb 16, 2024

Here's a tutorial for setting up two Kolibri apps https://kolibri-dev.readthedocs.io/en/develop/howtos/another_kolibri_instance.html

@iskipu
Copy link
Contributor

iskipu commented Feb 17, 2024

Hi @MisRob Can i work on this plz

@Abhishekzod007
Copy link

Hey @MisRob I wanna contribute on this issue. Can you assign me this?
Although most of the issues are assigned on "Studio" to someone so and I tried to work on that but people are working already working on these. So please assign me this atleast.

@MisRob
Copy link
Member

MisRob commented Feb 19, 2024

Hi @iskipu and @Abhishekzod007, thank you! I will assing @iskipu since they asked first here and @Abhishekzod007 I just assigned you another issue.

@MisRob
Copy link
Member

MisRob commented Feb 19, 2024

@Abhishekzod007 Have you seen our contributing guidelines? There are links to all unassigned "help wanted" issues and there's plenty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P1 - important Priority: High impact on UX
Projects
None yet
Development

No branches or pull requests

5 participants