Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new modal for connection testing with new strings #10141

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

bjester
Copy link
Member

@bjester bjester commented Feb 24, 2023

Summary

  • Adds new modal with necessary strings for giving the user feedback that the connection is being tested
  • Adds necessary new strings for error cases

Screenshot 2023-02-24 at 12 05 46 PM

References

Connects with #10133
Figma designs

Reviewer guidance

This modal is unused in this PR-- this is only for getting strings added to the codebase


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More new strings in, yes!!! 💯 :shipit:

@rtibbles
Copy link
Member

Linting error was live on develop, so merging here (has now been fixed on develop).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SIZE: medium TAG: user strings Application text that gets translated TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants