Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch core for changes if KDS option is provided, in devserver-with-kds #11785

Merged

Conversation

thesujai
Copy link
Contributor

Summary

As all kds components are linked to core, its better to watch core if kds path is provided, also suggested in #11667 (comment)

References

Fixes #11667

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: tools Internal tooling for development SIZE: very small labels Jan 25, 2024
@MisRob MisRob added the TODO: needs review Waiting for review label Jan 26, 2024
@nucleogenesis nucleogenesis self-assigned this Jan 26, 2024
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and it worked perfectly:

  • Ran yarn devserver-with-kds ../path/to/kds user_auth
  • Changed KTextbox to look really weird - the server reloaded and reflected my changes
  • Changed something in user_auth and it reloaded
  • Changed something in device and it did not reload

Thanks so much @thesujai for your work on this!

@iskipu
Copy link
Contributor

iskipu commented Jan 26, 2024

Nice work @thesujai 🎉 I have one question were u using linux for development ? bcz i tried the exact same solution few weeks back in my windows machine (#11667 (comment)) and it did not work properly ( mostly bcz of how powershell/cmd treats the arguments passed)

@rtibbles
Copy link
Member

Note that we may hold off on merging this until 0.16.0 has been released, in case there is any question about delays in merging!

@rtibbles rtibbles merged commit 11f8ead into learningequality:release-v0.16.x Feb 24, 2024
34 checks passed
@thesujai thesujai deleted the devserver-with-kds branch February 24, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: tools Internal tooling for development SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devserver-with-kds: The --watchonly flag being stops watching KDS changes
5 participants