Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin vue and vue-template-compiler to ensure correct version is used in kolibri-tools. #11930

Merged

Conversation

rtibbles
Copy link
Member

Summary

Pins vue and vue-template-compiler to exact versions so that consumers of the kolibri-tools package don't get accidentally upgraded to the 2.7 series of vue-template-compiler which is incompatible with our linting tools.

References

Needed to resolve linting error occurring in learningequality/studio#4462

Reviewer guidance

The main thing to note here is that the resolved version in the yarn.lock file has not changed, so this is purely a package export fix.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: tools Internal tooling for development SIZE: small labels Feb 29, 2024
@bjester bjester merged commit a19234a into learningequality:release-v0.16.x Mar 1, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: tools Internal tooling for development SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants