-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Update resources" option to Options dropdown #12137
Add "Update resources" option to Options dropdown #12137
Conversation
Build Artifacts
|
@@ -566,13 +573,19 @@ | |||
handleActiveSectionAction(opt) { | |||
const section_id = this.activeSection.section_id; | |||
const editRoute = this.$router.getRoute(PageNames.QUIZ_SECTION_EDITOR, { section_id }); | |||
const resourcesRoute = this.$router.getRoute(PageNames.QUIZ_SELECT_RESOURCES, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AllanOXDi, No blocker, just a clarification on whether this route would not need the optional topic_id
param too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this handleActiveSectionAction method so that it also checks against the string used for the label and routes the user to the select QUIZ_SELECT_RESOURCES route
No, The topic_id
is optional. From my understand of the above. ResourceSelection
component should be rendered when navigating to QUIZ_SELECT_RESOURCES route which expects an optional topic_id parameter and it can be accessed within the ResourceSelection component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @AllanOXDi.
I'll leave the final approval for @nucleogenesis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @AllanOXDi thanks for this! All looks good to me
Summary
This pull request adds "Update resources" option to the Options menu to enhance user flow
References
#12095
Reviewer guidance
go to "Options -> Edit Section" to open the side panel, then click "update resources' verify if everything works perfectly
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)