Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Update resources" option to Options dropdown #12137

Merged
merged 2 commits into from
May 14, 2024

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented May 7, 2024

Summary

This pull request adds "Update resources" option to the Options menu to enhance user flow

References

#12095

Reviewer guidance

go to "Options -> Edit Section" to open the side panel, then click "update resources' verify if everything works perfectly

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels May 7, 2024
@AllanOXDi AllanOXDi requested a review from akolson May 7, 2024 22:08
@AllanOXDi AllanOXDi requested a review from rtibbles May 7, 2024 22:10
@AllanOXDi AllanOXDi marked this pull request as ready for review May 8, 2024 00:16
@AllanOXDi AllanOXDi marked this pull request as draft May 8, 2024 15:28
@AllanOXDi AllanOXDi marked this pull request as ready for review May 8, 2024 19:43
@AllanOXDi AllanOXDi added the TODO: needs review Waiting for review label May 8, 2024
@@ -566,13 +573,19 @@
handleActiveSectionAction(opt) {
const section_id = this.activeSection.section_id;
const editRoute = this.$router.getRoute(PageNames.QUIZ_SECTION_EDITOR, { section_id });
const resourcesRoute = this.$router.getRoute(PageNames.QUIZ_SELECT_RESOURCES, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllanOXDi, No blocker, just a clarification on whether this route would not need the optional topic_id param too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this handleActiveSectionAction method so that it also checks against the string used for the label and routes the user to the select QUIZ_SELECT_RESOURCES route

No, The topic_id is optional. From my understand of the above. ResourceSelection component should be rendered when navigating to QUIZ_SELECT_RESOURCES route which expects an optional topic_id parameter and it can be accessed within the ResourceSelection component.

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @AllanOXDi.
I'll leave the final approval for @nucleogenesis

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @AllanOXDi thanks for this! All looks good to me

@AllanOXDi AllanOXDi merged commit 51c4207 into learningequality:develop May 14, 2024
31 checks passed
@AllanOXDi AllanOXDi deleted the Update-resources branch May 14, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants