First pass string updates following UX writing and ditto review #12312

marcellamaki · 2024-06-18T23:23:00Z

Summary

…

References

General updates to the add questions UI with alternative validation

When you have selected > 500 questions total

When you have a reasonable number of questions

Showing the number of replacements available

Selecting more questions that replacements available disables replacements

<= number of replacements means replacement button is enabled

…

Testing checklist

Contributor has fully tested the PR manually
If there are any front-end changes, before/after screenshots are included
Critical user journeys are covered by Gherkin stories
Critical and brittle code paths are covered by unit tests

PR process

PR has the correct target branch and milestone
PR has 'needs review' or 'work-in-progress' label
If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
If this is an important user-facing change, PR or related issue has a 'changelog' label
If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

Automated test coverage is satisfactory
PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

marcellamaki · 2024-06-18T23:23:56Z

packages/kolibri-common/strings/enhancedQuizManagementStrings.js

+  //   message:
+  //     "You've selected { selected, number } { selected, plural, one { question } other { questions } } to replace, but {available, plural, =0 { don't have questions } one { only have 1 question } other { only have { available } questions } } available to replace them with.",
+  //   context:
+  //     'Message of modal when a user tries to replace more questions than are available in the pool',


after doing manual QA will come back to this and make sure all scenarios are still covered

marcellamaki · 2024-06-18T23:25:40Z

packages/kolibri-common/strings/enhancedQuizManagementStrings.js

@@ -216,14 +209,14 @@ export const enhancedQuizManagementStrings = createTranslator('EnhancedQuizManag
  },
  cannotSelectSomeTopicWarning: {
    message:
-      'You can only select folders with { count, number } or less exercises and no subfolders to avoid oversized quizzes.',
+      'You can only select folders with 12 or fewer exercises.',


@rtibbles @nucleogenesis - do we want to keep this (and the "max number of questions 50" string) with this flexible syntax? maybe it's worth it it just seemed like we are not actually planning to add dynamic counts in either place

Yes, I deliberately updated it from the static string that was here previously to give us the flexibility to change this to whatever made the most sense.

The other thing here is whether this criterion is even the correct one - we could change it to just do it based on the number of questions available in the folder.

marcellamaki · 2024-06-18T23:39:35Z

packages/kolibri-common/strings/enhancedQuizManagementStrings.js

@@ -85,21 +85,18 @@ export const enhancedQuizManagementStrings = createTranslator('EnhancedQuizManag
    message: '{count, number} {count, plural, one {question selected} other {questions selected}}',
  },
  maxNumberOfQuestions: {
-    message: 'Max { count, number } { count, plural, one { question } other { questions }}',
+    message: 'Maximum number of questions is 50',


@rtibbles would we prefer to keep this as a dynamic option, rather than changing?

Yes, because I still think we should revisit whether 50 is the correct maximum - we've just assumed it, but I also think the user experience of a 50 max is terrible.

This parameterization still needs to be reinstated.

github-actions · 2024-06-18T23:53:50Z

Build Artifacts

Asset type	Download link
PEX file	kolibri-.pex
Windows Installer (EXE)	kolibri-0.17.0a0.dev0+git.68.gc689e748-windows-setup-unsigned.exe
Debian Package	kolibri_0.17.0a0.dev0+git.68.gc689e748-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.17.0a0.dev0+git.68.gc689e748-0.4.2.dmg
Android Package (APK)	kolibri-0.17.0a0.dev0+git.68.gc689e748-0.1.3-debug.apk
TAR file	kolibri-0.17.0a0.dev0+git.68.gc689e748.tar.gz
WHL file	kolibri-0.17.0a0.dev0+git.68.gc689e748-py2.py3-none-any.whl

rtibbles · 2024-06-18T23:56:14Z

packages/kolibri-common/strings/enhancedQuizManagementStrings.js

@@ -18,7 +18,7 @@ export const enhancedQuizManagementStrings = createTranslator('EnhancedQuizManag
    message: 'Quiz title',
  },
  addQuizSections: {
-    message: 'Add one or more sections to the quiz, according to your needs',
+    message: 'Add one or more sections, according to your needs',


My general thought about this string, is whether it is needed at all.

I have the same thought

I have no objections to eliminate this string! 💥

rtibbles · 2024-06-18T23:58:40Z

packages/kolibri-common/strings/enhancedQuizManagementStrings.js

+  //     'Message of modal when a user tries to replace more questions than are available in the pool',
+  // },
+  goBackAndUnselect: {
+    message: 'You can go back and unselect some questions to be able to perform the replacement.',


The only problem here is that at no point now are we telling the user how many replacements there are available, so they don't know how many to select.

There was a lot of discussion here about whether or not adding the numbers was helpful, or made things more confusing. I don't know if we will reach consensus... My thought is that we pick a direction and either we revisit in 0.18 when some of the workflow changes in general, or try to get some feedback on during training/observations or from our community? (maybe it's a bit granular to expect commentary on)

…mber of question options no, vs. folders/sub folders. Slightly rearranged side panel layout per ditto review

…t when there is a mis-match

rtibbles

A few things that are still broken here, and some strings not updated, most importantly.

rtibbles · 2024-06-19T23:48:37Z

kolibri/core/assets/src/constants.js

@@ -198,3 +198,5 @@ export const Presets = Object.freeze({
 // This should be kept in sync with the value in
 // kolibri/core/exams/constants.py
 export const MAX_QUESTIONS_PER_QUIZ_SECTION = 50;
+// this is not used for the actual exam model
+export const MAX_QUESTION_OPTIONS_PER_QUIZ_SECTION = 500;


I think we should just define this as a multiple of the constant above - either that, or it be dynamic depending on how many questions you are trying to select. But this is not required for string freeze.

rtibbles · 2024-06-19T23:50:14Z

kolibri/plugins/coach/assets/src/views/plan/CreateExamPage/ResourceSelection.vue

-                />
-              </div>
-            </div>
+      <h5 class="select-folder-style">


Regardless of whether it's in a KGridItem or not, it still needs to be in a v-else block, as this stuff isn't relevant for the 'Select Quiz' workflow.

rtibbles · 2024-06-19T23:51:23Z

packages/kolibri-common/strings/enhancedQuizManagementStrings.js

@@ -85,21 +85,18 @@ export const enhancedQuizManagementStrings = createTranslator('EnhancedQuizManag
    message: '{count, number} {count, plural, one {question selected} other {questions selected}}',
  },
  maxNumberOfQuestions: {
-    message: 'Max { count, number } { count, plural, one { question } other { questions }}',
+    message: 'Maximum number of questions is 50',


This parameterization still needs to be reinstated.

rtibbles · 2024-06-19T23:52:16Z

kolibri/plugins/coach/assets/src/views/plan/CreateExamPage/ResourceSelection.vue

+          backgroundColor: $themePalette.grey.v_100,
+        }"
+      >
+        {{ cannotSelectSomeTopicWarning$({ count: 500 }) }}


I am not seeing any updates to this string, which presumably will now say you can't select folders with more than 500 exercises instead.

May also be good to update the message id to be more about number of questions?

The updated string is this:

'You can only select entire folders when they have { count, number } questions or fewer.',

Is that what you mean?

although this does make me realize I should probably be using the const.... _const_istently! and not just adding 500 in random places

…acement side panel

pcenov · 2024-06-20T14:28:22Z

Hi @radinamatic,
As discussed here is a screenshot showing the potential confusion caused by the 'selected' word.

Also as discussed it's currently not possible to replace questions in this build so that's blocking the testing of some scenarios:

Cannot.repleace.a.question.mp4

I'll file the other observed issues separately.

radinamatic · 2024-06-20T14:35:47Z

To add to @pcenov's comment, here is another example where the confusion is apparent:

18 selected questions were actually selected and added in previous sections, but they are also reported as selected in the new, (third) section, which did not actually have any (0 questions selected at the bottom) selected at that point. That is very confusing.

…d referenced

radinamatic · 2024-06-20T14:40:05Z

If we could keep the count of questions in the card referring only to questions included in the previous section(s), and the counter at the bottom referring to questions actually selected for the current section, it might alleviate the confusion.

radinamatic · 2024-06-20T14:41:45Z

And please, could we revert the default number of questions in the input field to 0? 🙏🏽

rtibbles · 2024-06-20T15:11:28Z

And please, could we revert the default number of questions in the input field to 0?

We should not default an input value to an unusable value - then it is not a default. The default of 10 is a sensible value for a reasonable number of questions to add to the section, which can save users from an extra decision if they are in a rush, which we know many of the teachers using our tools are.

rtibbles · 2024-06-20T15:13:37Z

If we could keep the count of questions in the card referring only to questions included in the previous section(s), and the counter at the bottom referring to questions actually selected for the current section, it might alleviate the confusion.

Yes, I think this makes sense - I would suggest that we update the wording on the card to X questions in quiz, Y total or something like that?

radinamatic · 2024-06-20T15:32:15Z

We should not default an input value to an unusable value - then it is not a default. The default of 10 is a sensible value for a reasonable number of questions to add to the section, which can save users from an extra decision if they are in a rush, which we know many of the teachers using our tools are.

Maybe I'm too nitpicky, but I strongly dislike (and especially in a rush) when the decisions are taken for me (and from me) by an inanimate tool (or its makers). I see the usefulness of the value 0 as the most straightforward (usable) message that the there is still a decision pending on my part on how many questions I need to add, and that I should not proceed until I make that determination. However, I guess we could only exit this impasse with a proper user testing.

rtibbles · 2024-06-20T15:36:53Z

However, I guess we could only exit this impasse with a proper user testing.

Yes, and a quick skim of all the feedback we've ever had about quizzes - we've never had a request to remove the existing default of 10 questions for a quiz, which this is a continuation of. If anything, the main requests have been asking for more automation, not less.

marcellamaki · 2024-06-20T15:45:53Z

Yes, @radinamatic I totally see what you're saying, and I think I may personally lean the same way, but I also think @rtibbles has offered a good reminder that we have gotten feedback around "plz more automatic", and that the current default behavior is 10 questions (even though, I agree that somehow it feels a bit different in this scenario). I think let's stick with it for now and see what feedback we get! We can make adjustments in 0.18, as we'll continue to update these workflows.

radinamatic · 2024-06-20T15:47:43Z

I would suggest that we update the wording on the card to X questions in quiz, Y total or something like that?

Would this be good: X questions already used, of Y previously selected? Not too long?

rtibbles · 2024-06-20T15:48:01Z

The other thing that this workflow allows, at least, is to more easily and granularly change your mind - by deleting specific questions, or adding more, so hopefully that reduces the frustration for the @marcellamaki and @radinamatic user types out there!

marcellamaki · 2024-06-20T18:03:55Z

Simplified wording on the replace questions flow:

if the the replacements are "equal" - string reflects this and button is in available state

if there are an unequal number of replacements selected (more or less) Select X to continue is displayed, and button is in inactive state

radinamatic · 2024-06-20T18:56:05Z

Yeah, that might be the simplest solution at this point...

radinamatic · 2024-06-20T19:17:00Z

It still stutters, when more than required are selected, and does not update the count properly when one by one checkboxes are being de-selected:

count-deselect-flop.mp4

radinamatic · 2024-06-20T19:27:43Z

Ok, the above is not string-related, so we should be ready to go! 🎉

radinamatic · 2024-06-20T19:33:17Z

packages/kolibri-common/strings/enhancedQuizManagementStrings.js

+  },
+  noResourcesAvailable: {
+    message:
+      'There are no resources on your device yet. Ask an administrator to add resources to your device.',


Don't we have these 2 strings already in some common strings file?

cc @marcellamaki @rtibbles

Similar ones, but neither of these :)

radinamatic

Ready for string freeze lift-off! 🚀 ✈️ 🎉

rtibbles

Nothing blocking here, have suggested a couple of tweaks to @marcellamaki directly.

First pass string updates following UX writing and ditto review

951f2ba

github-actions bot added the SIZE: small label Jun 18, 2024

marcellamaki commented Jun 18, 2024

View reviewed changes

rtibbles reviewed Jun 18, 2024

View reviewed changes

marcellamaki added 6 commits June 19, 2024 18:56

Additional edit to string file for string freeze

2145f5a

Refactor resource selection to simplify UX. validation against max nu…

3adaaaf

…mber of question options no, vs. folders/sub folders. Slightly rearranged side panel layout per ditto review

Fix broken string reference keys

b38c9c9

Fix checkbox bug

583e8e2

Display number of replacement questions available. Disable replacemen…

3f68cf8

…t when there is a mis-match

Cleanup now-unused insufficient replacements modal

15d16b9

marcellamaki force-pushed the post-ditto-review-strings-and-ui-changes branch from 1562488 to 15d16b9 Compare June 19, 2024 23:33

github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: medium labels Jun 19, 2024

Remove stray reference to NotEnoughReplacementsModal

5a50ffe

marcellamaki force-pushed the post-ditto-review-strings-and-ui-changes branch from f2942c9 to 5a50ffe Compare June 19, 2024 23:47

rtibbles requested changes Jun 19, 2024

View reviewed changes

marcellamaki added 2 commits June 19, 2024 20:13

Reinstate v-else condition which should not have been removed

6d4a533

reinstate parameterization in string

fb7b65c

marcellamaki force-pushed the post-ditto-review-strings-and-ui-changes branch from 1759a06 to fb7b65c Compare June 20, 2024 00:15

clean up unused strings

8966326

marcellamaki force-pushed the post-ditto-review-strings-and-ui-changes branch from 59e2ac5 to 8966326 Compare June 20, 2024 00:38

github-actions bot added the SIZE: large label Jun 20, 2024

marcellamaki added 3 commits June 19, 2024 20:54

remove unused function

37a2689

reinstate string I shouldn't have deleted

8e832d5

Ensure sectionTitle displays properly and doesn't break question repl…

8dca44e

…acement side panel

Make sure activeSection title related values are properly imported an…

00c010f

…d referenced

pcenov mentioned this pull request Jun 20, 2024

Issues when creating a quiz without having imported resources or users enrolled in the class #12330

Open

rtibbles and others added 3 commits June 20, 2024 09:16

Update unused question messaging to be consistent across all node types.

19a74e7

Add additional strings to explain no learner or no resources scenarios

e80e52f

Ensure simplified replacement direction string is used

cccf97f

Remove duplicative header

20023b2

radinamatic reviewed Jun 20, 2024

View reviewed changes

Remove unused exercises variable passed into string

99ab30a

radinamatic approved these changes Jun 20, 2024

View reviewed changes

rtibbles approved these changes Jun 20, 2024

View reviewed changes

rtibbles merged commit d887f89 into learningequality:develop Jun 20, 2024
30 of 31 checks passed

First pass string updates following UX writing and ditto review #12312

First pass string updates following UX writing and ditto review #12312

Conversation

marcellamaki commented Jun 18, 2024 • edited Loading

Summary

References

Testing checklist

PR process

Reviewer checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rtibbles left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pcenov commented Jun 20, 2024

radinamatic commented Jun 20, 2024

radinamatic commented Jun 20, 2024

radinamatic commented Jun 20, 2024

rtibbles commented Jun 20, 2024

rtibbles commented Jun 20, 2024

radinamatic commented Jun 20, 2024

rtibbles commented Jun 20, 2024

marcellamaki commented Jun 20, 2024

radinamatic commented Jun 20, 2024

rtibbles commented Jun 20, 2024

marcellamaki commented Jun 20, 2024

radinamatic commented Jun 20, 2024

radinamatic commented Jun 20, 2024

radinamatic commented Jun 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radinamatic left a comment

Choose a reason for hiding this comment

rtibbles left a comment

Choose a reason for hiding this comment

marcellamaki commented Jun 18, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading