Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load application stack of plugins in order to enable/disable #1563

Closed
wants to merge 1 commit into from

Conversation

benjaoming
Copy link
Contributor

Summary

This is a proof of concept for #186 - a concept that I suggested and reject, therefore also closing the PR immediately. It's just to illustrate.

@benjaoming benjaoming closed this May 30, 2017
@codecov-io
Copy link

codecov-io commented May 30, 2017

Codecov Report

Merging #1563 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1563      +/-   ##
===========================================
+ Coverage    73.12%   73.14%   +0.02%     
===========================================
  Files          144      144              
  Lines         4759     4763       +4     
  Branches       517      517              
===========================================
+ Hits          3480     3484       +4     
  Misses        1215     1215              
  Partials        64       64
Impacted Files Coverage Δ
kolibri/utils/cli.py 31.25% <ø> (-0.54%) ⬇️
kolibri/plugins/learn/kolibri_plugin.py 100% <100%> (ø) ⬆️
kolibri/plugins/coach/kolibri_plugin.py 100% <100%> (ø) ⬆️
kolibri/plugins/user/kolibri_plugin.py 100% <100%> (ø) ⬆️
kolibri/plugins/management/kolibri_plugin.py 100% <100%> (ø) ⬆️
kolibri/plugins/setup_wizard/kolibri_plugin.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75cdd05...4b99587. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants