Android Tweaks

[DXCanas]

• Resolves Import/Export from External SD Card kolibri-installer-android#5
• Resolves Channel import does not work. kolibri-installer-android#16, which re-broke due to the tqdm package importing multiprocessing?
• Resolves Android N+ Compatibility kolibri-installer-android#35

[DXCanas]

@aronasorman what's left to make this ready to merge? I tried importing multiprocessing rather than the myhero dummy package, but I'm getting a bunch of flake8 errors.

[aronasorman]

I remember we needed to get space usage working properly before we can actually import content. But that can be a separate PR.

[DXCanas]

@aronasorman ah you're right.

@jamalex I'm still trying to figure out some JNI issues with Kevin, but Aron and I have a hunch that the import page isn't working because of some space calculation stuff in Morango - was that what you were talking about when I first kicked off?

[indirectlylit]

closing PR until it's time to revisit this work

[codecov]

Codecov Report

Merging #4158 into develop will decrease coverage by 0.23%.
The diff coverage is 18.18%.

@@             Coverage Diff             @@
##           develop    #4158      +/-   ##
===========================================
- Coverage     51.2%   50.97%   -0.24%     
===========================================
  Files          864      870       +6     
  Lines        26668    26799     +131     
  Branches      3552     3572      +20     
===========================================
+ Hits         13656    13660       +4     
- Misses       12268    12385     +117     
- Partials       744      754      +10

Impacted Files	Coverage Δ
.../core/content/management/commands/importcontent.py	92.37% <ø> (-0.07%)	⬇️
kolibri/utils/system.py	30.35% <0%> (-3.31%)	⬇️
kolibri/core/tasks/management/commands/base.py	76.78% <100%> (+0.11%)	⬆️
kolibri/core/analytics/pskolibri/common.py	76.81% <100%> (+0.34%)	⬆️
kolibri/core/discovery/utils/filesystem/posix.py	62.37% <12.5%> (-4.65%)	⬇️
...ach/assets/src/modules/classSummary/dataHelpers.js	44% <0%> (-17.37%)	⬇️
...ins/coach/assets/src/modules/classSummary/index.js	40% <0%> (-1.94%)	⬇️
.../assets/src/views/reports/ReportsGroupListPage.vue	0% <0%> (ø)	⬆️
...h/assets/src/views/home/HomePage/OverviewBlock.vue	0% <0%> (ø)	⬆️
...ssets/src/views/reports/ReportsLearnerListPage.vue	0% <0%> (ø)	⬆️
... and 34 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7f35c...3ae1202. Read the comment docs.

[DXCanas]

@jamalex @ralphiee22 The shim is effective in granting access to the import from studio workflow, but I get this error:

When I try to open up a channel's page. Are file size reports a morango thing?

[indirectlylit]

DO NOT ACKNOWLEDGE. I JUST NEED THE ARTIFACTS

Acknowledged

[jamalex]

Are file size reports a morango thing?

No, they're calculated here:
https://github.com/learningequality/kolibri/blob/develop/kolibri/core/discovery/utils/filesystem/posix.py#L89

If you have a QPython shell, you could try some of those things interactively on an Android device.

(Note: this is about free disk space, not file sizes)

[indirectlylit]

I haven't tested, but nothing in here looks problematic to me

[benjaoming]

This is targeted for 0.11.x, but the tqdm removal was targeted for 0.12?

[indirectlylit]

this can be retargeted to 0.12

[DXCanas]

I targeted at 0.11 because I’ve been testing with it most. I’ve built a few with 0.12 but had several styling issues (this wasn’t that recent).

…

On Fri, Feb 1, 2019 at 9:48 AM Devon Rueckner ***@***.***> wrote: this can be retargeted to 0.12 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4158 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJa5XP4IcItJaJ6fv6JSlPMSfE1M3FXJks5vJH3TgaJpZM4V7lRv> .

[indirectlylit]

originally the goal was to release with 0.11 but that boat sailed, so we can just target 0.12 now

[benjaoming]

Thanks :) I was also wondering, but given the motivation behind the tqdm removal, I hope we can get this in for 0.12 👍

[indirectlylit]

Yeah I approved it a while ago - @DXCanas are you still working on it?

[indirectlylit]

changed target to develop which introduced conflict in base.txt

[DXCanas]

Not working on it anymore. I'll handle the conflict then merge?

[DXCanas]

@indirectlylit rebased. Figured it would be a cleaner merge that way

[benjaoming]

18.18% of diff hit (target 51.2%)

Is there a way @DXCanas that this can be tested, or is it too Android-specific? Some mocks perhaps?

[indirectlylit]

good call @benjaoming -

I opened a new issue and targeted it to 0.12.1 so this doesn't become a blocker: #4907