Update metadata labels. #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtibbles
requested changes
Apr 12, 2022
|
Can you ensure that this PR is rebased to latest develop? The linting and tests should all be passing. |
|
I checked and tried to rebase but it was last one. I also did pre-commit to check if everything is okay with linting |
|
My local machine and github is giving different results for linting. Reorder is the problem. |
rtibbles
requested changes
Apr 26, 2022
There was a problem hiding this comment.
Still some updates to do here.
I have had similar issues with the import sorting - it seems to be something to do with whether modules are available locally or not when the import sorting happens, but I've not found a good fix for it. Would be good to work out if you have any ideas.
rtibbles
approved these changes
May 12, 2022
|
Hrm, not sure why but locally my pre-commit is now agreeing with the github action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new labels for metadata in ricecooker and validate them with le_utils
fixes #367