Account for duplicate file sizes and speed up channel list page loading #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonboiser
reviewed
Jun 21, 2017
| if cached_data: | ||
| return cached_data | ||
| tree_id = self.main_tree.tree_id | ||
| files = File.objects.select_related('contentnode').select_related('assessment_item')\ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jonboiser
reviewed
Jun 21, 2017
| tree_id = self.main_tree.tree_id | ||
| files = File.objects.select_related('contentnode').select_related('assessment_item')\ | ||
| .filter(Q(contentnode__tree_id=tree_id) | Q(assessment_item__contentnode__tree_id=tree_id))\ | ||
| .values('checksum', 'file_size').distinct().aggregate(resource_size=Sum('file_size')) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@jayoshih Could you give me some steps on how to test this? |
|
@jonboiser If you upload a file multiple times, does it add the file size multiple times under the following locations? Content items: File uploader: Publish Modal: Import: |
jonboiser
approved these changes
Jun 22, 2017
|
Ok, tested it out on both modals, and it looks good. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.