Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading offline indicator #3851

Merged

Conversation

akolson
Copy link
Member

@akolson akolson commented Nov 29, 2022

Summary

Description of the change(s) you made

This pr removes the misleading offline message on the sign-in page. it also updates the dependency url for jsPDF to its new location on Github.

Manual verification steps performed

See #3226 for steps

Screenshots (if applicable)

Before

Screenshot from 2021-07-07 15-48-39

After

Screenshot 2022-11-29 at 22 05 35


Reviewer guidance

How can a reviewer test these changes?

  1. Go to /en/accounts/#/ unauthenticated
  2. Open Chrome's Dev Tools and the Network tab or Click the Toggle device toolbar
  3. Change network throttling to "Offline"
  4. The misleading offline message should not be displayed on the sign-in.(See before and after screenshots)

References

Closes #3226

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson added this to the Studio usability enhancements milestone Nov 29, 2022
@akolson akolson requested review from bjester, radinamatic, nucleogenesis and rtibbles and removed request for nucleogenesis November 29, 2022 19:39
@akolson akolson marked this pull request as ready for review November 29, 2022 19:53
@pcenov
Copy link
Member

pcenov commented Dec 5, 2022

Yes, this is implemented as specified above @radinamatic

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 👍🏽 :shipit:

@bjester bjester merged commit 2289f6c into learningequality:unstable Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor's offline indicator showing on sign-in page
4 participants