tasks done by Karam Karim #4
Conversation
BlackGhost3
changed the title
karam-karim/task-3/index.html
Outdated
| <body> | ||
|
|
||
| <div class="container"> | ||
| <ui class="dropdown" data-text="Select Language"> |
There was a problem hiding this comment.
typo, It meant to be ul not ui.
karam-karim/reload.js
Outdated
| */ | ||
| setTimeout(a => location.reload(true), 2000); | ||
|
|
||
| }; |
There was a problem hiding this comment.
yeah but you don't need js here. Used it locally
There was a problem hiding this comment.
sorry I added this my mistake, It won't be here on next push.
karam-karim/task-1/style.css
Outdated
| width: 70%; | ||
| } | ||
|
|
||
| .container > .body > .langs > span { |
There was a problem hiding this comment.
you can instead make this shorter ?
There was a problem hiding this comment.
I could add a class or id to the element to target them directly, the reason that I made it this way it's easier to read for me and understand what i'm styling, but if you don't like this type of selectors I can change it 😃
karam-karim/task-1/style.css
Outdated
| margin: 20px; | ||
| } | ||
|
|
||
| .container > .header > h2, .container > .header > p{ |
There was a problem hiding this comment.
same goes here, you can make this selector shorter as well
karam-karim/task-1/style.css
Outdated
| margin: .5em 1em; | ||
| } | ||
|
|
||
| .container > .body > .langs > span > label{ |
karam-karim/task-1/style.css
Outdated
| cursor: pointer; | ||
| } | ||
|
|
||
| .container > .body > .langs > span > input[type="checkbox"]:checked + label{ |
karam-karim/task-1/style.css
Outdated
| padding: 2em 1em; | ||
| } | ||
|
|
||
| .container > .body > .buttons > a{ |
There was a problem hiding this comment.
here too and check others as well
karam-karim/task-3/style.css
Outdated
| list-style: none; | ||
| position: relative; | ||
| border-radius: 5px; | ||
|
|
There was a problem hiding this comment.
you are missing shadow in dropdown
There was a problem hiding this comment.
okay, sorry about this one it was 2 am and I didn't notice it in the pics.
BlackGhost3
changed the title
No description provided.