Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port kubetop to Python 3 #30

Closed
jason-kane opened this issue Apr 17, 2017 · 7 comments
Closed

port kubetop to Python 3 #30

jason-kane opened this issue Apr 17, 2017 · 7 comments

Comments

@jason-kane
Copy link

pip3 install kubetop on 16.04 ubuntu leads to:

$ kubetop 
Traceback (most recent call last):
  File "/usr/local/bin/kubetop", line 7, in <module>
    from kubetop._script import main
  File "/usr/local/lib/python3.5/dist-packages/kubetop/_script.py", line 27, in <module>
    from ._textrenderer import Sink, kubetop
  File "/usr/local/lib/python3.5/dist-packages/kubetop/_textrenderer.py", line 114
    def _render_pod_top(reactor, (node_info, pod_info)):
                                 ^
SyntaxError: invalid syntax
@jason-kane
Copy link
Author

jason-kane commented Apr 17, 2017

@exarkun
Copy link
Contributor

exarkun commented Apr 18, 2017

Indeed. kubetop is currently Python 2-only. pip install kubetop (per the instructions in the README) will succeed.

Presumably there are more issues than just this syntax error preventing it from running on Python 3. For example, the txkube dependency is also Python 2-only. So porting that to Python 3 would be a first step to addressing this.

@exarkun exarkun changed the title _render_pod_top syntax error port kubetop to Python 3 May 17, 2017
@gjcarneiro
Copy link

IMHO a new tool like kubetop should be Python 3 only from the start. Why bother with Python 2 in 2017?...

@exarkun
Copy link
Contributor

exarkun commented May 17, 2017

IMHO a new tool like kubetop should be Python 3 only from the start. Why bother with Python 2 in 2017?...

I eagerly await your PR.

@jason-kane
Copy link
Author

I opened the ticket but am not a kubetop developer so couldn't merge even if I knew the codebase well enough to adequately review. I think you want @exarkun.

@rodrigc
Copy link
Contributor

rodrigc commented Apr 6, 2018

I just wanted to let you know that things are in progress. exarkun will of course be doing the reviews and any merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants