For load-config :carica/json, directly open an io/reader on resource #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.openStream is a java.net.URL method, which means, if you pass "something io/reader could handle, but not a URL" you get a "No matching field found: openStream" exception. For example, a java.net.URI, which io/reader handles fine, threw that exception. Basically, the assumption was that load-config was only ever called on a resource directly returned from io/resource (which returns java.net.URL because that is what ClassLoader/getResource returns), but that's not necessarily always true for anyone calling load-config with json from a java.net.URI, or a java.io.File, or even a string -- "(carica/load-config "/path/to/some.json")" would also throw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.openStream is a java.net.URL method, which means, if you pass "something io/reader could
handle, but not a URL" you get a "No matching field found: openStream" exception.
For example, a java.net.URI, which io/reader handles fine, threw that exception. Basically,
the assumption was that load-config was only ever called on a resource directly returned
from io/resource (which returns java.net.URL because that is what ClassLoader/getResource
returns), but that's not necessarily always true for anyone calling load-config with json
from a java.net.URI, or a java.io.File, or even a string -- "(carica/load-config
"/path/to/some.json")" would also throw.