-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add delegation #579
Merged
Merged
feat: add delegation #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
feat/delegation
branch
6 times, most recently
from
February 1, 2021 17:01
7e697f2
to
9291ae3
Compare
kyranjamie
force-pushed
the
feat/delegation
branch
8 times, most recently
from
February 10, 2021 12:31
4cce51c
to
dc3845b
Compare
kyranjamie
force-pushed
the
feat/delegation
branch
2 times, most recently
from
February 10, 2021 15:22
f4f97e1
to
6a67e04
Compare
aulneau
approved these changes
Feb 10, 2021
app/pages/stacking/delegated-stacking/components/choose-delegator-stx-address.tsx
Outdated
Show resolved
Hide resolved
kyranjamie
force-pushed
the
feat/delegation
branch
3 times, most recently
from
February 12, 2021 10:48
34d2a1c
to
742b987
Compare
kyranjamie
force-pushed
the
feat/delegation
branch
from
February 12, 2021 11:05
742b987
to
76e6083
Compare
kyranjamie
force-pushed
the
feat/delegation
branch
from
February 12, 2021 15:25
880a461
to
ec173d2
Compare
hstove
approved these changes
Feb 12, 2021
kyranjamie
force-pushed
the
feat/delegation
branch
5 times, most recently
from
February 15, 2021 14:36
3464cbd
to
f305d92
Compare
kyranjamie
force-pushed
the
feat/delegation
branch
2 times, most recently
from
February 22, 2021 10:16
d6f5cfe
to
531e52f
Compare
feat: add delegation flow fix: thomas comments Co-authored-by: Thomas Osmonson <aulneau@users.noreply.github.com>
chore: improve error handling if wait tx fails
kyranjamie
force-pushed
the
feat/delegation
branch
5 times, most recently
from
February 22, 2021 17:01
bf94d84
to
5341538
Compare
kyranjamie
force-pushed
the
feat/delegation
branch
from
February 23, 2021 09:37
5341538
to
56f0c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delegation flow
delegate-stacking-flow.mp4
Notes regarding Stacking changes, #605
PR also introduces better fee handling behaviours than were previously in place for Stacking. These changes ensure we **never** adjust the tx amount to handle the fee. A behaviour reminiscent of when _Stack everything_ was your only option.
We validate input below if you stack within a fee's worth of your entire balance.
And Send Max will go just a little bit under your entire balance.
Disable direct stacking option when balance too low [screenshot]
blocked by Support mainnet or testnet addresses on any derivation path Zondax/ledger-stacks#52Tested on mainnet