Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delegation #579

Merged
merged 10 commits into from
Feb 23, 2021
Merged

feat: add delegation #579

merged 10 commits into from
Feb 23, 2021

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Jan 29, 2021

Download the latest build

Delegation flow

delegate-stacking-flow.mp4
Notes regarding Stacking changes, #605
PR also introduces better fee handling behaviours than were previously in place for Stacking. These changes ensure we **never** adjust the tx amount to handle the fee. A behaviour reminiscent of when _Stack everything_ was your only option.

We validate input below if you stack within a fee's worth of your entire balance.

image

And Send Max will go just a little bit under your entire balance.

Disable direct stacking option when balance too low [screenshot]

image

@kyranjamie kyranjamie force-pushed the feat/delegation branch 6 times, most recently from 7e697f2 to 9291ae3 Compare February 1, 2021 17:01
@markmhendrickson markmhendrickson linked an issue Feb 2, 2021 that may be closed by this pull request
@kyranjamie kyranjamie force-pushed the feat/delegation branch 8 times, most recently from 4cce51c to dc3845b Compare February 10, 2021 12:31
@kyranjamie kyranjamie force-pushed the feat/delegation branch 2 times, most recently from f4f97e1 to 6a67e04 Compare February 10, 2021 15:22
@aulneau aulneau self-requested a review February 10, 2021 19:38
app/components/home/stacking-promo-card.tsx Outdated Show resolved Hide resolved
app/components/icons/delegated-icon.tsx Outdated Show resolved Hide resolved
app/hooks/use-latest-nonce.ts Show resolved Hide resolved
app/modals/revoke-delegation/steps/stacking-failed.tsx Outdated Show resolved Hide resolved
app/modals/transaction/transaction-modal.tsx Show resolved Hide resolved
app/pages/stacking/components/delegated-stacking-terms.tsx Outdated Show resolved Hide resolved
@kyranjamie kyranjamie force-pushed the feat/delegation branch 3 times, most recently from 34d2a1c to 742b987 Compare February 12, 2021 10:48
@kyranjamie kyranjamie changed the title chore: add delegation feat: add delegation Feb 12, 2021
@kyranjamie kyranjamie marked this pull request as ready for review February 12, 2021 13:17
app/constants/index.ts Show resolved Hide resolved
app/hooks/use-create-ledger-tx.ts Show resolved Hide resolved
@kyranjamie kyranjamie force-pushed the feat/delegation branch 5 times, most recently from bf94d84 to 5341538 Compare February 22, 2021 17:01
@kyranjamie kyranjamie merged commit 14816c1 into master Feb 23, 2021
@kyranjamie kyranjamie deleted the feat/delegation branch February 23, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment