-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linalg algos #224
Update linalg algos #224
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 67.56% 68.19% +0.63%
==========================================
Files 65 65
Lines 5515 5515
==========================================
+ Hits 3726 3761 +35
+ Misses 1789 1754 -35 ☔ View full report in Codecov by Sentry. |
Should we try to do the same testing/cleanups/updates for the "aa" functions? |
missed some debugging lines
fix formatting
We can if you like. I only targeted the parts that were used by the beamformer so I wasn't sure if it was worth it |
It's worth a look at what's in cuBLAS to see if there is a straight forward way to add a aa_batched function. |
Slightly related - can you add the texture size change from #210 to linalg? Otherwise I think this PR is good since it doesn't look like there is much we can do with aa_batched. |
Apply fix for #210
I think it was just that one liner from Torrance right? I added it into linalg_kernels.cu Is there anything else we want to do here? If it's ready to go, I'll let someone else be the one to close/commit etc |
As long as this last round of tests don't explode I think it's ready to go. |
Updated the linalg algorithms to tune for performance