Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linalg algos #224

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Update linalg algos #224

merged 5 commits into from
Dec 7, 2023

Conversation

dentalfloss1
Copy link
Collaborator

Updated the linalg algorithms to tune for performance

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1233200) 67.56% compared to head (af885c0) 68.19%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   67.56%   68.19%   +0.63%     
==========================================
  Files          65       65              
  Lines        5515     5515              
==========================================
+ Hits         3726     3761      +35     
+ Misses       1789     1754      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/linalg.cu Outdated Show resolved Hide resolved
src/linalg.cu Outdated Show resolved Hide resolved
@jaycedowell
Copy link
Collaborator

Should we try to do the same testing/cleanups/updates for the "aa" functions?

missed some debugging lines
fix formatting
@dentalfloss1
Copy link
Collaborator Author

dentalfloss1 commented Nov 14, 2023

Should we try to do the same testing/cleanups/updates for the "aa" functions?

We can if you like. I only targeted the parts that were used by the beamformer so I wasn't sure if it was worth it

@jaycedowell
Copy link
Collaborator

It's worth a look at what's in cuBLAS to see if there is a straight forward way to add a aa_batched function.

@jaycedowell
Copy link
Collaborator

Slightly related - can you add the texture size change from #210 to linalg? Otherwise I think this PR is good since it doesn't look like there is much we can do with aa_batched.

@dentalfloss1
Copy link
Collaborator Author

I think it was just that one liner from Torrance right? I added it into linalg_kernels.cu Is there anything else we want to do here? If it's ready to go, I'll let someone else be the one to close/commit etc

@jaycedowell
Copy link
Collaborator

As long as this last round of tests don't explode I think it's ready to go.

@jaycedowell jaycedowell merged commit 3c68028 into master Dec 7, 2023
13 checks passed
@jaycedowell jaycedowell deleted the update-linalg-algos branch December 7, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants