-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using different classes for each setting #87
Conversation
Prior to this, only one class name could be used for all settings within a Rails model.
I'll take care of these build errors when I get a chance. Please ignore the PR for now. |
Tests are finally passing, but I think I'll just add some more tests to cover persistence thoroughly. |
Hi @ledermann, first off thanks for your work on this gem, it's been super handy for us. Please let me know what you think of this PR, if you're willing to support the feature I propose it'd be great. |
Great work, thanks! |
Hm, the changes break my own application using RailsSettings, so I reverted them. Sadly I don't have the time to investigate... |
What versions of Ruby & Rails are you using? |
This update will allow us to set a custom
:class_name
for each setting. For example:This also accidentally solves #57 .