Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PR - Maintain Rails 3 compatibility in #reset_read_marks_for_user #72

Merged

Conversation

bcavileer
Copy link
Contributor

Specs pass

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 86311ae on bcavileer:rails3_fix_reset_read_marks_for_user into 689f9fd on ledermann:master.

@ledermann
Copy link
Owner

Hm, why is this change needed? The gem is already compatible with Rails 3.

@bcavileer
Copy link
Contributor Author

I get errors because of the mass assignment.

This removes the mass assignment without having to use anything like if
defined?(ProtectedAttributes)
On Mar 29, 2016 2:08 AM, "Georg Ledermann" notifications@github.com wrote:

Hm, why is this change needed? The gem is already compatible with Rails 3.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#72 (comment)

@ledermann ledermann merged commit bf0452d into ledermann:master Mar 31, 2016
@ledermann
Copy link
Owner

You are right, I have merged you PR. Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants