Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS::S3->add_bucket location param is undocumented and buggy #9

Closed
autarch opened this issue Apr 12, 2018 · 7 comments
Closed

AWS::S3->add_bucket location param is undocumented and buggy #9

autarch opened this issue Apr 12, 2018 · 7 comments
Assignees
@leejo

Comments

@autarch
Copy link
Contributor

autarch commented Apr 12, 2018

This parameter is not documented. While it shouldn't be required, it's passed to the request whether it was specified or not. So if I don't specify it then it ends up being passed as an undef and failing the TC for the AWS::S3::Request::CreateBucket location attribute.
@autarch autarch changed the title AWS::S3->add_buckey location param is undocumented and buggy AWS::S3->add_bucket location param is undocumented and buggy Apr 12, 2018
@leejo leejo self-assigned this Apr 13, 2018
@leejo leejo closed this as completed in 454bb7a Apr 13, 2018
@leejo
Copy link
Owner

leejo commented Apr 13, 2018

Version 0.14 on its way to CPAN shortly. Thanks!

@autarch
Copy link
Contributor Author

autarch commented Apr 20, 2018

Actually, I don't think this fixed it. You can't pass "us-east-1" as a location constraint to S3. It responds with "The specified location-constraint is not valid". I think you can pass any other location though. This is dumb, but that's how S3 defines it.

@leejo
Copy link
Owner

leejo commented Apr 20, 2018

Gah! Thanks for the report, will fix.

@leejo leejo reopened this Apr 20, 2018
@autarch
Copy link
Contributor Author

autarch commented Apr 20, 2018

Actually, that may not be right. I'll explore further.

@leejo
Copy link
Owner

leejo commented Apr 20, 2018

Let me know, I've got a version here ready to upload that passes an empty string as the default rather than us-east-1

leejo added a commit that referenced this issue Apr 20, 2018
@leejo
fix #9 - (?) default empty locations to empty string
98b98cf 
You can't pass "us-east-1" as a location constraint to S3. It responds
with "The specified location-constraint is not valid". I think you can
pass any other location though. This is dumb, but that's how S3 defines
it.

w/r/t 454bb7a
leejo added a commit that referenced this issue Apr 20, 2018
@leejo
fix #9 - (?) default empty locations to empty string
e068125 
You can't pass "us-east-1" as a location constraint to S3. It responds
with "The specified location-constraint is not valid". I think you can
pass any other location though. This is dumb, but that's how S3 defines
it.

w/r/t 454bb7a
@autarch autarch mentioned this issue Apr 20, 2018
Merged
@autarch
Copy link
Contributor Author

autarch commented Apr 20, 2018

I did some live testing. My PR fixes the issue.

@leejo
Copy link
Owner

leejo commented Apr 20, 2018

Closing - as per #10

@leejo leejo closed this as completed Apr 20, 2018
@ThinkerYzu ThinkerYzu mentioned this issue Mar 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leejo leejo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@autarch @leejo