Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden vs Hidden-only #61

Closed
Dragomir-Ivanov opened this issue Aug 21, 2018 · 2 comments · Fixed by #66
Closed

Hidden vs Hidden-only #61

Dragomir-Ivanov opened this issue Aug 21, 2018 · 2 comments · Fixed by #66

Comments

@Dragomir-Ivanov
Copy link

Hi
Currently hidden-* classes hide only for certain screen size. It can become somewhat tedious for example to specify a hidden element for hidden-sm hidden-lg hidden-xlg. Also it is not consistent with say boostrap similar classes. My proposal is to replace current hidden-* classes with hidden-only-* and have change hidden-* to include stated and bigger screens, so hidden-sm will hide things for sm, lg, xlg etc.

@despecial
Copy link

I agree and would suggest this naming pattern

hide-for-sm
hide-sm

@Yoann-M
Copy link
Contributor

Yoann-M commented Feb 28, 2021

Hello, I allow myself a little 🆙 on this topic.
If we take a look about the Responsive Utilities in the Bootstrap V4 Alpha release, the proposal focuses on:

  • .hidden-sm-down to hide size sm and smaller
  • .hidden-sm-up to hide size sm and bigger
  • .hidden-sm to hide size sm only

So, if we take a look about the Bootstrap Responsive utilities code and its Breakpoints mixins dependencies, we can easily use it inside Reflex. I tried it and it works great 👍

👀 I see two things to define :

  • Define the naming for Hidden utilities (we can keep the ones already defined)
  • To introduce _breakpoints.scss, we may need to put it in a folder named mixins (this might change the architecture a bit)

Good to Know :
In Bootstrap V5 "Responsive utilities" are replaced by the Display Properties. Guess it's a good idea for Bootstrap ... but not for Reflex as it's done in Flex ... We don't need to handle display: block properties 😃.

Yoann-M added a commit to Yoann-M/reflex that referenced this issue Feb 28, 2021
Yoann-M added a commit to Yoann-M/reflex that referenced this issue Feb 28, 2021
Yoann-M added a commit to Yoann-M/reflex that referenced this issue Feb 28, 2021
Yoann-M added a commit to Yoann-M/reflex that referenced this issue Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants